-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zk log change #170
zk log change #170
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #170 +/- ##
===========================================
- Coverage 67.65% 66.58% -1.07%
===========================================
Files 88 88
Lines 5484 5491 +7
===========================================
- Hits 3710 3656 -54
- Misses 1388 1450 +62
+ Partials 386 385 -1
Continue to review full report at Codecov.
|
logger.Warnf("RegisterTempNode(root{%s}, node{%s}) = error{%v}", root, node, perrors.WithStack(err)) | ||
} else { | ||
logger.Errorf("RegisterTempNode(root{%s}, node{%s}) = error{%v}", root, node, perrors.WithStack(err)) | ||
} | ||
return perrors.WithMessagef(err, "RegisterTempNode(root{%s}, node{%s})", root, node) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function will return error. And outer function will catch the error ,continue to call logger.Error. If you need to ignore the error, I think you should modify all error catch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function will return error. And outer function will catch the error ,continue to call logger.Error. If you need to ignore the error, I think you should modify all error catch.
For now, there is no way to print this error except by calling the Interface Methods peripherally.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: