Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zk log change #170

Merged
merged 3 commits into from
Aug 19, 2019
Merged

zk log change #170

merged 3 commits into from
Aug 19, 2019

Conversation

pantianying
Copy link
Member

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

codecov-io commented Aug 19, 2019

Codecov Report

Merging #170 into develop will decrease coverage by 1.06%.
The diff coverage is 20%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #170      +/-   ##
===========================================
- Coverage    67.65%   66.58%   -1.07%     
===========================================
  Files           88       88              
  Lines         5484     5491       +7     
===========================================
- Hits          3710     3656      -54     
- Misses        1388     1450      +62     
+ Partials       386      385       -1
Impacted Files Coverage Δ
registry/zookeeper/registry.go 62.6% <0%> (-0.8%) ⬇️
registry/zookeeper/listener.go 58.13% <33.33%> (-3.4%) ⬇️
protocol/dubbo/pool.go 59.23% <0%> (-15.77%) ⬇️
protocol/dubbo/listener.go 54.16% <0%> (-10.65%) ⬇️
protocol/dubbo/codec.go 73.52% <0%> (-8.83%) ⬇️
protocol/dubbo/readwriter.go 71.79% <0%> (-2.57%) ⬇️
registry/etcdv3/registry.go 56.89% <0%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83b3b9c...d065108. Read the comment docs.

logger.Warnf("RegisterTempNode(root{%s}, node{%s}) = error{%v}", root, node, perrors.WithStack(err))
} else {
logger.Errorf("RegisterTempNode(root{%s}, node{%s}) = error{%v}", root, node, perrors.WithStack(err))
}
return perrors.WithMessagef(err, "RegisterTempNode(root{%s}, node{%s})", root, node)
Copy link
Contributor

@hxmhlt hxmhlt Aug 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function will return error. And outer function will catch the error ,continue to call logger.Error. If you need to ignore the error, I think you should modify all error catch.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function will return error. And outer function will catch the error ,continue to call logger.Error. If you need to ignore the error, I think you should modify all error catch.

For now, there is no way to print this error except by calling the Interface Methods peripherally.

@hxmhlt hxmhlt merged commit c32af7b into apache:develop Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants