Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(loadbalance): add unittests for p2c #1686

Merged
merged 4 commits into from
Dec 25, 2021
Merged

Conversation

justxuewei
Copy link
Member

@justxuewei justxuewei commented Dec 23, 2021

What this PR does:

  • The unit test coverage in the p2c load balance is up to 82.6%.
  • Remove protocol.NewRPCResult from the code.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

Codecov Report

Merging #1686 (f1bf1cb) into 3.0 (0e195d1) will increase coverage by 0.17%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1686      +/-   ##
==========================================
+ Coverage   41.22%   41.40%   +0.17%     
==========================================
  Files         254      255       +1     
  Lines       14614    14664      +50     
==========================================
+ Hits         6025     6072      +47     
- Misses       7893     7894       +1     
- Partials      696      698       +2     
Impacted Files Coverage Δ
protocol/invocation/rpcinvocation.go 15.83% <ø> (ø)
protocol/result.go 0.00% <ø> (ø)
cluster/cluster/available/cluster_invoker.go 73.33% <33.33%> (ø)
cluster/loadbalance/p2c/loadbalance.go 76.36% <72.72%> (ø)
filter/sentinel/filter.go 52.45% <100.00%> (ø)
metrics/prometheus/reporter.go 28.57% <0.00%> (+1.71%) ⬆️
...tocol/rest/server/server_impl/go_restful_server.go 44.82% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e195d1...f1bf1cb. Read the comment docs.

Copy link
Contributor

@Lvnszn Lvnszn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit 6710138 into apache:3.0 Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants