Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support $invokeAsync #1674

Merged
merged 2 commits into from
Dec 20, 2021
Merged

support $invokeAsync #1674

merged 2 commits into from
Dec 20, 2021

Conversation

luky116
Copy link
Contributor

@luky116 luky116 commented Dec 19, 2021

Fixes: #1511 #1627

@codecov-commenter
Copy link

Codecov Report

Merging #1674 (2a61862) into 3.0 (e376834) will increase coverage by 0.15%.
The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1674      +/-   ##
==========================================
+ Coverage   41.15%   41.30%   +0.15%     
==========================================
  Files         254      254              
  Lines       14590    14614      +24     
==========================================
+ Hits         6005     6037      +32     
+ Misses       7888     7879       -9     
- Partials      697      698       +1     
Impacted Files Coverage Δ
cluster/cluster/base/cluster_invoker.go 24.44% <0.00%> (+0.26%) ⬆️
cluster/cluster/forking/cluster_invoker.go 58.33% <0.00%> (ø)
protocol/invocation/rpcinvocation.go 15.83% <0.00%> (-1.44%) ⬇️
cluster/cluster/failfast/cluster_invoker.go 71.42% <100.00%> (ø)
cluster/cluster/failover/cluster_invoker.go 66.66% <100.00%> (ø)
cluster/cluster/zoneaware/cluster_invoker.go 80.55% <100.00%> (ø)
filter/generic/service_filter.go 73.58% <100.00%> (ø)
filter/generic/util.go 66.66% <100.00%> (-2.30%) ⬇️
config/config_center_config.go 50.00% <0.00%> (-0.49%) ⬇️
config/registry_config.go 20.51% <0.00%> (+1.66%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e376834...2a61862. Read the comment docs.

@xfstart07
Copy link
Contributor

可以提个 1.5 的 PR 吗?

@luky116
Copy link
Contributor Author

luky116 commented Dec 20, 2021

可以提个 1.5 的 PR 吗?

好的,我今晚提交下

@luky116 luky116 changed the title add $invokeAsync support $invokeAsync Dec 20, 2021
@AlexStocks AlexStocks merged commit 48d0313 into apache:3.0 Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants