Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unified nacos user and password obtaining path #1645

Merged
merged 2 commits into from
Dec 5, 2021

Conversation

binbin0325
Copy link
Member

What this PR does:
The user name and password of nacos are obtained from the configuration, not from param
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

Codecov Report

Merging #1645 (27efe5e) into 3.0 (0603eed) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1645      +/-   ##
==========================================
+ Coverage   41.04%   41.15%   +0.10%     
==========================================
  Files         253      253              
  Lines       14501    14506       +5     
==========================================
+ Hits         5952     5970      +18     
+ Misses       7860     7845      -15     
- Partials      689      691       +2     
Impacted Files Coverage Δ
config/config_center_config.go 50.48% <100.00%> (+0.48%) ⬆️
config_center/nacos/impl.go 75.24% <100.00%> (ø)
metadata/report/nacos/report.go 40.00% <100.00%> (+1.76%) ⬆️
metadata/report/delegate/delegate_report.go 35.09% <0.00%> (+8.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0603eed...27efe5e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants