Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: service register url's group and version key with "" value. #1612

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

LaurenceLiZhixin
Copy link
Contributor

As for java client, if user set 'version' to '1.0.0" and doesn't set 'group' key. the reference url's param contains version=1.0.0 and doesn't contain 'group' key.
But golang server regster 'group' key with "" value even if user didn't configure service's 'group' field in config file.
That's a bug. I open this pr is to let url to be register, doesn't contain group or value key, if user didn't set.

@LaurenceLiZhixin LaurenceLiZhixin changed the title fix: fix service group and version key fix: service register url's group and version key with "" value. Nov 25, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1612 (5e2b72f) into 3.0 (1c92dde) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1612      +/-   ##
==========================================
- Coverage   40.94%   40.91%   -0.03%     
==========================================
  Files         251      251              
  Lines       14403    14405       +2     
==========================================
- Hits         5897     5894       -3     
- Misses       7826     7830       +4     
- Partials      680      681       +1     
Impacted Files Coverage Δ
config/service_config.go 10.90% <0.00%> (-0.08%) ⬇️
filter/metrics/filter.go 85.00% <0.00%> (-15.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c92dde...5e2b72f. Read the comment docs.

@AlexStocks AlexStocks merged commit fe19465 into 3.0 Nov 25, 2021
@justxuewei justxuewei deleted the fix/groupVersionKey branch August 15, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants