Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nacos servicediscovery group、namespace #1581

Merged
merged 2 commits into from
Nov 11, 2021
Merged

fix: nacos servicediscovery group、namespace #1581

merged 2 commits into from
Nov 11, 2021

Conversation

LaurenceLiZhixin
Copy link
Contributor

@LaurenceLiZhixin LaurenceLiZhixin commented Nov 10, 2021

  • nacos servicediscovery group and namespace support
  • zk registry group support
  • zk registry enhancement

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2021

Codecov Report

Merging #1581 (b02124d) into 3.0 (001f95c) will increase coverage by 0.20%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1581      +/-   ##
==========================================
+ Coverage   41.75%   41.96%   +0.20%     
==========================================
  Files         258      258              
  Lines       15137    15131       -6     
==========================================
+ Hits         6321     6350      +29     
+ Misses       8077     8044      -33     
+ Partials      739      737       -2     
Impacted Files Coverage Δ
registry/base_registry.go 1.27% <0.00%> (+0.04%) ⬆️
registry/nacos/service_discovery.go 1.06% <0.00%> (-0.01%) ⬇️
registry/zookeeper/registry.go 1.25% <0.00%> (ø)
registry/nacos/registry.go 48.17% <100.00%> (+0.38%) ⬆️
filter/metrics/filter.go 85.00% <0.00%> (-15.00%) ⬇️
config_center/apollo/listener.go 78.26% <0.00%> (-4.35%) ⬇️
metrics/prometheus/reporter.go 26.85% <0.00%> (-1.72%) ⬇️
remoting/kubernetes/listener.go 52.83% <0.00%> (ø)
remoting/kubernetes/registry_controller.go 51.62% <0.00%> (+0.97%) ⬆️
remoting/kubernetes/client.go 71.91% <0.00%> (+2.24%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c85c55...b02124d. Read the comment docs.

@justxuewei justxuewei merged commit fce2f73 into 3.0 Nov 11, 2021
@justxuewei justxuewei deleted the fix/nacos-2.0 branch August 15, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants