Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.5 fix the nacos namespace from server/client.yml does not take e… #1576

Merged
merged 2 commits into from
Nov 10, 2021

Conversation

Mulavar
Copy link
Member

@Mulavar Mulavar commented Nov 8, 2021

…ffect

What this PR does:

Which issue(s) this PR fixes:

Fixes # #1573

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@Mulavar Mulavar changed the title [#1573]fix the nacos namespace from server/client.yml does not take e… [#1573]1.5 fix the nacos namespace from server/client.yml does not take e… Nov 8, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1576 (e785d0d) into 1.5 (a4b4f50) will increase coverage by 0.02%.
The diff coverage is 54.16%.

❗ Current head e785d0d differs from pull request most recent head 2cb57ab. Consider uploading reports for the commit 2cb57ab to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              1.5    #1576      +/-   ##
==========================================
+ Coverage   55.72%   55.75%   +0.02%     
==========================================
  Files         279      279              
  Lines       16024    16072      +48     
==========================================
+ Hits         8930     8961      +31     
- Misses       6153     6167      +14     
- Partials      941      944       +3     
Impacted Files Coverage Δ
common/logger/logger.go 92.75% <ø> (ø)
common/logger/logging.go 80.00% <0.00%> (-20.00%) ⬇️
config/config_center_config.go 66.21% <ø> (+5.19%) ⬆️
config/consumer_config.go 58.69% <ø> (ø)
config/protocol_config.go 100.00% <ø> (ø)
protocol/dubbo/impl/package.go 62.06% <ø> (ø)
protocol/invocation/rpcinvocation.go 16.66% <0.00%> (-0.61%) ⬇️
registry/service_instance.go 0.00% <ø> (ø)
protocol/dubbo/impl/codec.go 41.50% <20.00%> (-0.16%) ⬇️
registry/nacos/registry.go 43.84% <40.00%> (-0.51%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22ec982...2cb57ab. Read the comment docs.

@@ -34,10 +34,10 @@ import (
// DynamicConfiguration
// ////////////////////////////////////////
const (
// DEFAULT_GROUP: default group
// DEFAULT_GROUP default group
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不删除原有常量是发现有其他地方在用(apollo、file),尚不清楚这两个的具体实现,因此为了避免歧义新增了常量。

@zhaoyunxing92 zhaoyunxing92 added this to the v1.5.8 milestone Nov 10, 2021
@zhaoyunxing92 zhaoyunxing92 added bug Something isn't working enhancement New feature or request labels Nov 10, 2021
@zhaoyunxing92 zhaoyunxing92 merged commit 5a90f47 into apache:1.5 Nov 10, 2021
@zhaoyunxing92 zhaoyunxing92 changed the title [#1573]1.5 fix the nacos namespace from server/client.yml does not take e… 1.5 fix the nacos namespace from server/client.yml does not take e… Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants