register not use metadata configuration. #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binbin0325
force-pushed
the
20211102_nacos
branch
2 times, most recently
from
420814a
to
707df34
Compare
AlexStocks
reviewed
Nov 6, 2021
binbin0325
force-pushed
the
20211102_nacos
branch
3 times, most recently
from
67ff14a
to
6ad5a32
Compare
Codecov Report
@@ Coverage Diff @@
## 3.0 #1565 +/- ##
==========================================
- Coverage 41.81% 41.75% -0.06%
==========================================
Files 258 258
Lines 15117 15137 +20
==========================================
Hits 6321 6321
- Misses 8055 8077 +22
+ Partials 741 739 -2
Continue to review full report at Codecov.
|
|
Thanks for your contribution, I'll test it locally to confirm soon. |
justxuewei
reviewed
Nov 8, 2021
justxuewei
reviewed
Nov 8, 2021
|
mark：该 pr 也修复了 #1573 |
Mulavar
reviewed
Nov 8, 2021
registry/nacos/service_discovery.go
Outdated
| common.WithParams(url.GetParams()), | ||
| common.WithParamsValue(constant.NacosUsername, url.Username), | ||
| common.WithParamsValue(constant.NacosPassword, url.Password), | ||
| common.WithParamsValue(constant.NacosNamespaceID, url.GetParam(constant.NamespaceKey, ""))) |
There was a problem hiding this comment.
还有一个问题，假如用户没设置 namespace，在 config_center_config.go 里，给这个字段设置了一个默认值 dubbo，所以 url.GetParam(constant.NamespaceKey, "") 这个代码应该永远不会返回 ""，需要改一下 namespace 在 config_center_config.go 的默认值。
binbin0325
force-pushed
the
20211102_nacos
branch
from
6ad5a32
to
0b33524
Compare
Mulavar
approved these changes
Nov 9, 2021
justxuewei
reviewed
Nov 9, 2021
|
@Mulavar |
cjphaha
approved these changes
Nov 10, 2021
zhaoyunxing92
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
1:service register not use metadata configuration.
2:metadata-type=local , metadata information will not be uploaded to the configuration center
Which issue(s) this PR fixes:
Fixes :#1544
Special notes for your reviewer:
Does this PR introduce a user-facing change?: