Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: set default refernce check to true #1531

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Conversation

LaurenceLiZhixin
Copy link
Contributor

@LaurenceLiZhixin LaurenceLiZhixin commented Oct 21, 2021

fix: #1364

@codecov-commenter
Copy link

Codecov Report

Merging #1531 (4206fc2) into 3.0 (c1263de) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1531      +/-   ##
==========================================
- Coverage   41.93%   41.78%   -0.15%     
==========================================
  Files         259      259              
  Lines       15132    15132              
==========================================
- Hits         6345     6323      -22     
- Misses       8047     8066      +19     
- Partials      740      743       +3     
Impacted Files Coverage Δ
config/reference_config.go 0.00% <ø> (ø)
metadata/report/delegate/delegate_report.go 26.49% <0.00%> (-8.61%) ⬇️
remoting/kubernetes/watch.go 76.85% <0.00%> (-3.71%) ⬇️
remoting/kubernetes/client.go 69.66% <0.00%> (-2.25%) ⬇️
remoting/kubernetes/registry_controller.go 50.64% <0.00%> (-0.98%) ⬇️
remoting/kubernetes/listener.go 52.83% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1263de...4206fc2. Read the comment docs.

Copy link
Member

@justxuewei justxuewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaurenceLiZhixin LaurenceLiZhixin merged commit a15f72a into 3.0 Oct 25, 2021
justxuewei pushed a commit to justxuewei/dubbo-go that referenced this pull request Oct 28, 2021
* fix: change default check to true

* fix: update triple version
@justxuewei justxuewei deleted the ftr/default-check branch August 15, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants