Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftr: add fatal method for logger(config-enhance branch) #1482

Merged
merged 2 commits into from
Sep 26, 2021

Conversation

cjphaha
Copy link
Member

@cjphaha cjphaha commented Sep 25, 2021

  • Logger 接口添加 fatal 和 fatalf 方法
  • 由于 zap 的 fatal 方法会调用 os.Exit 因此导入了 "bou.ke/monkey" 包用于测试 fatal,防止因执行 logger.Fatal 导致单测 ci 失败

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2021

Codecov Report

Merging #1482 (e7b18c0) into config-enhance (2072171) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           config-enhance    #1482      +/-   ##
==================================================
+ Coverage           43.16%   43.20%   +0.03%     
==================================================
  Files                 273      273              
  Lines               15179    15179              
==================================================
+ Hits                 6552     6558       +6     
+ Misses               7862     7858       -4     
+ Partials              765      763       -2     
Impacted Files Coverage Δ
registry/nacos/listener.go 81.73% <0.00%> (+2.60%) ⬆️
cluster/cluster_impl/base_cluster_invoker.go 65.95% <0.00%> (+3.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2072171...e7b18c0. Read the comment docs.

@AlexStocks AlexStocks merged commit 26aa12b into apache:config-enhance Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants