Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362 #1388

Conversation

ChangedenCZD
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #1362

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2021

Codecov Report

Merging #1388 (7ce990a) into 1.5 (467c867) will decrease coverage by 2.57%.
The diff coverage is 60.00%.

❗ Current head 7ce990a differs from pull request most recent head 1e99454. Consider uploading reports for the commit 1e99454 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              1.5    #1388      +/-   ##
==========================================
- Coverage   58.07%   55.49%   -2.58%     
==========================================
  Files         275      276       +1     
  Lines       13381    15948    +2567     
==========================================
+ Hits         7771     8851    +1080     
- Misses       4650     6159    +1509     
+ Partials      960      938      -22     
Impacted Files Coverage Δ
config/config_loader.go 43.40% <0.00%> (+4.56%) ⬆️
config/provider_config.go 62.06% <0.00%> (+7.52%) ⬆️
config/reference_config.go 80.00% <0.00%> (-1.67%) ⬇️
config_center/nacos/facade.go 62.50% <0.00%> (-27.16%) ⬇️
registry/consul/registry.go 51.64% <0.00%> (+2.31%) ⬆️
...gistry/event/protocol_ports_metadata_customizer.go 65.78% <ø> (+6.41%) ⬆️
registry/kubernetes/registry.go 64.15% <0.00%> (+13.03%) ⬆️
registry/zookeeper/listener.go 26.58% <0.00%> (-42.65%) ⬇️
remoting/etcdv3/client.go 55.69% <0.00%> (+2.69%) ⬆️
remoting/etcdv3/facade.go 0.00% <0.00%> (ø)
... and 308 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2ddb7a...1e99454. Read the comment docs.

Copy link
Contributor

@zhaoyunxing92 zhaoyunxing92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这类代码很多,可以考虑统一下,要么考虑下url#GetParamDuration

remoting/getty/config.go Outdated Show resolved Hide resolved
remoting/getty/config.go Outdated Show resolved Hide resolved
remoting/getty/config.go Outdated Show resolved Hide resolved
@ChangedenCZD
Copy link
Contributor Author

这类代码很多,可以考虑统一下,要么考虑下url#GetParamDuration

功能不一致,且在1.5分支没找到对应代码

remoting/getty/config.go Outdated Show resolved Hide resolved
@LaurenceLiZhixin LaurenceLiZhixin merged commit deaf1a7 into apache:1.5 Aug 27, 2021
@ChangedenCZD ChangedenCZD deleted the feature/fix_the_exception_when_tcp_timeout_is_less_than_1_for_1.5 branch September 9, 2021 08:10
@zhaoyunxing92 zhaoyunxing92 added this to the v1.5.7 milestone Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants