Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: struct2MapAll logics #1356

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Conversation

justxuewei
Copy link
Member

@justxuewei justxuewei commented Jul 30, 2021

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2021

Codecov Report

Merging #1356 (6ab300a) into 1.5 (467c867) will increase coverage by 0.48%.
The diff coverage is 67.22%.

❗ Current head 6ab300a differs from pull request most recent head ef04f90. Consider uploading reports for the commit ef04f90 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              1.5    #1356      +/-   ##
==========================================
+ Coverage   58.07%   58.56%   +0.48%     
==========================================
  Files         275      282       +7     
  Lines       13381    16335    +2954     
==========================================
+ Hits         7771     9566    +1795     
- Misses       4650     5771    +1121     
- Partials      960      998      +38     
Impacted Files Coverage Δ
config/config_loader.go 43.40% <0.00%> (+4.56%) ⬆️
config/provider_config.go 62.06% <0.00%> (+7.52%) ⬆️
config/reference_config.go 80.00% <0.00%> (-1.67%) ⬇️
remoting/zookeeper/listener.go 42.79% <0.00%> (+1.51%) ⬆️
config/config_center_config.go 66.21% <33.33%> (+2.03%) ⬆️
registry/directory/directory.go 77.89% <58.33%> (+2.14%) ⬆️
protocol/dubbo/dubbo_invoker.go 70.29% <60.00%> (+0.97%) ⬆️
filter/filter_impl/generic_filter.go 62.50% <65.38%> (-8.72%) ⬇️
protocol/grpc/server.go 77.14% <66.66%> (+3.80%) ⬆️
registry/etcdv3/listener.go 74.00% <71.42%> (+6.50%) ⬆️
... and 291 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e781ec...ef04f90. Read the comment docs.

@AlexStocks AlexStocks merged commit 2dca192 into apache:1.5 Aug 3, 2021
@justxuewei justxuewei deleted the fix/struct2map-1.5 branch August 3, 2021 02:05
@zhaoyunxing92 zhaoyunxing92 added this to the v1.5.7 milestone Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants