Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix the black list bug and make ConnCheckRouter work well #1287

Merged
merged 6 commits into from
Jul 12, 2021

Conversation

cvictory
Copy link
Contributor

@cvictory cvictory commented Jun 29, 2021

  1. change pageSize to 64;
  2. make the black recover by Service: different service can recover at the same time.
  3. fix routeChain.notify just global lock. The lock should also in service dimension.

The feature about router is not supported in 3.0, so I will not submit to 3.0.

1. change pageSize to 64;
2. make the black recover by Service: different service can recover at the same time.
3. fix routeChain.notify just global lock. The lock should also in service Dimension
make the blackList belong to one service.
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2021

Codecov Report

Merging #1287 (467c867) into 1.5 (a10ff4d) will decrease coverage by 8.06%.
The diff coverage is 60.04%.

❗ Current head 467c867 differs from pull request most recent head 5dc973a. Consider uploading reports for the commit 5dc973a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              1.5    #1287      +/-   ##
==========================================
- Coverage   66.13%   58.07%   -8.07%     
==========================================
  Files         174      275     +101     
  Lines        9343    13381    +4038     
==========================================
+ Hits         6179     7771    +1592     
- Misses       2541     4650    +2109     
- Partials      623      960     +337     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster_invoker.go 66.66% <ø> (-6.67%) ⬇️
cluster/cluster_impl/broadcast_cluster_invoker.go 76.47% <ø> (-3.53%) ⬇️
cluster/cluster_impl/failfast_cluster_invoker.go 66.66% <ø> (-4.77%) ⬇️
cluster/cluster_impl/mock_cluster.go 0.00% <0.00%> (ø)
cluster/loadbalance/random.go 100.00% <ø> (ø)
cluster/router/healthcheck/factory.go 66.66% <0.00%> (ø)
common/extension/auth.go 0.00% <ø> (ø)
common/extension/cluster.go 0.00% <ø> (ø)
common/extension/cluster_interceptor.go 0.00% <0.00%> (ø)
common/extension/config_center.go 0.00% <ø> (ø)
... and 390 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdd488f...5dc973a. Read the comment docs.

protocol/rpc_status.go Outdated Show resolved Hide resolved
protocol/rpc_status.go Outdated Show resolved Hide resolved
@LaurenceLiZhixin LaurenceLiZhixin added the enhancement New feature or request label Jul 6, 2021
@LaurenceLiZhixin LaurenceLiZhixin removed the enhancement New feature or request label Jul 6, 2021
@zouyx zouyx merged commit f5acb35 into apache:1.5 Jul 12, 2021
@zhaoyunxing92 zhaoyunxing92 added this to the v1.5.7 milestone Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants