Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Key generate Func in ServiceEvent #1286

Merged
merged 4 commits into from
Jul 11, 2021

Conversation

cvictory
Copy link
Contributor

Add Key Func in ServiceEvent, so that the developer can extend the Key generate method.

@cvictory cvictory changed the base branch from master to 3.0 June 29, 2021 07:43
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2021

Codecov Report

Merging #1286 (ba494dd) into 3.0 (968650f) will decrease coverage by 4.77%.
The diff coverage is 55.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1286      +/-   ##
==========================================
- Coverage   59.53%   54.75%   -4.78%     
==========================================
  Files         259      277      +18     
  Lines       12737    13156     +419     
==========================================
- Hits         7583     7204     -379     
- Misses       4199     5040     +841     
+ Partials      955      912      -43     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/broadcast_cluster_invoker.go 76.47% <ø> (ø)
cluster/cluster_impl/failfast_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/mock_cluster.go 0.00% <0.00%> (ø)
cluster/loadbalance/random.go 100.00% <ø> (ø)
common/extension/auth.go 0.00% <ø> (ø)
common/extension/cluster.go 0.00% <ø> (ø)
common/extension/cluster_interceptor.go 0.00% <0.00%> (ø)
common/extension/config_center.go 0.00% <ø> (ø)
common/extension/config_center_factory.go 0.00% <ø> (ø)
... and 291 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 893bfb5...ba494dd. Read the comment docs.

registry/event.go Outdated Show resolved Hide resolved
@LaurenceLiZhixin LaurenceLiZhixin added this to the v3.0.0 milestone Jul 2, 2021
@LaurenceLiZhixin LaurenceLiZhixin self-assigned this Jul 6, 2021
@AlexStocks AlexStocks merged commit 103aa72 into apache:3.0 Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants