Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Key Func in ServiceEvent #1285

Merged
merged 5 commits into from
Jul 4, 2021
Merged

Conversation

cvictory
Copy link
Contributor

Add Key Func in ServiceEvent, so that the developer can extend the Key generate method.

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2021

Codecov Report

Merging #1285 (7e6dbcb) into 1.5 (a10ff4d) will decrease coverage by 9.11%.
The diff coverage is 59.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.5    #1285      +/-   ##
==========================================
- Coverage   66.13%   57.02%   -9.12%     
==========================================
  Files         174      280     +106     
  Lines        9343    13672    +4329     
==========================================
+ Hits         6179     7796    +1617     
- Misses       2541     4913    +2372     
- Partials      623      963     +340     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster_invoker.go 66.66% <ø> (-6.67%) ⬇️
cluster/cluster_impl/broadcast_cluster_invoker.go 76.47% <ø> (-3.53%) ⬇️
cluster/cluster_impl/failfast_cluster_invoker.go 66.66% <ø> (-4.77%) ⬇️
cluster/cluster_impl/mock_cluster.go 0.00% <0.00%> (ø)
cluster/loadbalance/random.go 100.00% <ø> (ø)
cluster/router/healthcheck/factory.go 66.66% <0.00%> (ø)
common/extension/auth.go 0.00% <ø> (ø)
common/extension/cluster.go 0.00% <ø> (ø)
common/extension/cluster_interceptor.go 0.00% <0.00%> (ø)
common/extension/config_center.go 0.00% <ø> (ø)
... and 394 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdd488f...7e6dbcb. Read the comment docs.

@AlexStocks AlexStocks requested review from gaoxinge and zouyx July 3, 2021 23:42
@AlexStocks AlexStocks merged commit e3d486e into apache:1.5 Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants