Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Djh/doc imports #1282

Merged
merged 2 commits into from
Jun 29, 2021
Merged

Djh/doc imports #1282

merged 2 commits into from
Jun 29, 2021

Conversation

Mulavar
Copy link
Member

@Mulavar Mulavar commented Jun 27, 2021

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

Codecov Report

Merging #1282 (8d250aa) into 1.5 (a10ff4d) will decrease coverage by 7.79%.
The diff coverage is 59.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.5    #1282      +/-   ##
==========================================
- Coverage   66.13%   58.34%   -7.80%     
==========================================
  Files         174      274     +100     
  Lines        9343    13330    +3987     
==========================================
+ Hits         6179     7777    +1598     
- Misses       2541     4593    +2052     
- Partials      623      960     +337     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster_invoker.go 66.66% <ø> (-6.67%) ⬇️
cluster/cluster_impl/broadcast_cluster_invoker.go 76.47% <ø> (-3.53%) ⬇️
cluster/cluster_impl/failfast_cluster_invoker.go 66.66% <ø> (-4.77%) ⬇️
cluster/cluster_impl/mock_cluster.go 0.00% <0.00%> (ø)
cluster/loadbalance/random.go 100.00% <ø> (ø)
cluster/router/healthcheck/factory.go 66.66% <0.00%> (ø)
common/extension/auth.go 0.00% <ø> (ø)
common/extension/cluster.go 0.00% <ø> (ø)
common/extension/cluster_interceptor.go 0.00% <0.00%> (ø)
common/extension/config_center.go 0.00% <ø> (ø)
... and 388 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdd488f...8d250aa. Read the comment docs.

Copy link
Contributor

@cvictory cvictory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit 5b7b35b into apache:1.5 Jun 29, 2021
@Mulavar Mulavar deleted the djh/doc-imports branch August 12, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants