Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: when zk remoting.EventTypeAdd event send fail, need delete the path from zk listener pathmap #1273

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

jack15083
Copy link
Contributor

@jack15083 jack15083 commented Jun 23, 2021

What this PR does:

Which issue(s) this PR fixes:

Fixes #1274

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

Codecov Report

Merging #1273 (0442424) into 1.5 (a10ff4d) will decrease coverage by 7.63%.
The diff coverage is 60.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.5    #1273      +/-   ##
==========================================
- Coverage   66.13%   58.50%   -7.64%     
==========================================
  Files         174      273      +99     
  Lines        9343    13273    +3930     
==========================================
+ Hits         6179     7765    +1586     
- Misses       2541     4542    +2001     
- Partials      623      966     +343     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster_invoker.go 66.66% <ø> (-6.67%) ⬇️
cluster/cluster_impl/broadcast_cluster_invoker.go 76.47% <ø> (-3.53%) ⬇️
cluster/cluster_impl/failfast_cluster_invoker.go 66.66% <ø> (-4.77%) ⬇️
cluster/cluster_impl/mock_cluster.go 0.00% <0.00%> (ø)
cluster/loadbalance/random.go 100.00% <ø> (ø)
cluster/router/healthcheck/factory.go 66.66% <0.00%> (ø)
common/extension/auth.go 0.00% <ø> (ø)
common/extension/cluster.go 0.00% <ø> (ø)
common/extension/cluster_interceptor.go 0.00% <0.00%> (ø)
common/extension/config_center.go 0.00% <ø> (ø)
... and 388 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b195b50...0442424. Read the comment docs.

@jack15083 jack15083 changed the title 修复zk EventTypeAdd事件发送失败时,造成的服务不能发现的问题 Fix: when zk remoting.EventTypeAdd event send fail, need delete the path from zk listener pathmap Jun 23, 2021
@LaurenceLiZhixin LaurenceLiZhixin added this to the v3.0.0 milestone Jun 25, 2021
@LaurenceLiZhixin LaurenceLiZhixin merged commit 66fbce2 into apache:1.5 Jun 25, 2021
@Da-Hong
Copy link

Da-Hong commented Jul 12, 2021

上面用的这个dubboPath
_, ok := l.pathMap[dubboPath]
下面用成zkPath了
delete(l.pathMap, zkPath)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants