Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ineffassign #127

Merged
merged 3 commits into from
Jul 11, 2019
Merged

Fix: ineffassign #127

merged 3 commits into from
Jul 11, 2019

Conversation

AlexStocks
Copy link
Contributor

What this PR does:
to delete ineffassign error.

common/rpc_service_test.go Show resolved Hide resolved
registry/zookeeper/registry_test.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Jul 11, 2019

Codecov Report

Merging #127 into master will increase coverage by 0.07%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   67.64%   67.72%   +0.07%     
==========================================
  Files          69       69              
  Lines        4349     4347       -2     
==========================================
+ Hits         2942     2944       +2     
+ Misses       1106     1102       -4     
  Partials      301      301
Impacted Files Coverage Δ
registry/zookeeper/registry.go 63.4% <ø> (-0.31%) ⬇️
config_center/zookeeper/impl.go 40.42% <50%> (ø) ⬆️
remoting/zookeeper/listener.go 48.64% <0%> (+1.62%) ⬆️
config_center/zookeeper/listener.go 86.95% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 357822e...b4735e3. Read the comment docs.

@AlexStocks AlexStocks merged commit e582cc0 into apache:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants