Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: delete dubbo-cli, update triple version #1259

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

LaurenceLiZhixin
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@LaurenceLiZhixin LaurenceLiZhixin requested review from gaoxinge, zouyx and AlexStocks and removed request for gaoxinge and zouyx June 15, 2021 13:07
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2021

Codecov Report

Merging #1259 (35e1d2e) into 3.0 (968650f) will decrease coverage by 3.88%.
The diff coverage is 50.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1259      +/-   ##
==========================================
- Coverage   59.53%   55.65%   -3.89%     
==========================================
  Files         259      273      +14     
  Lines       12737    12826      +89     
==========================================
- Hits         7583     7138     -445     
- Misses       4199     4783     +584     
+ Partials      955      905      -50     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/broadcast_cluster_invoker.go 76.47% <ø> (ø)
cluster/cluster_impl/failfast_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/mock_cluster.go 0.00% <0.00%> (ø)
cluster/loadbalance/random.go 100.00% <ø> (ø)
...router/v3router/judger/list_string_match_judger.go 0.00% <0.00%> (ø)
...ster/router/v3router/judger/method_match_judger.go 0.00% <0.00%> (ø)
...er/router/v3router/judger/url_label_match_judge.go 0.00% <0.00%> (ø)
common/extension/auth.go 0.00% <ø> (ø)
common/extension/cluster.go 0.00% <ø> (ø)
... and 282 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99bcbee...35e1d2e. Read the comment docs.

@LaurenceLiZhixin LaurenceLiZhixin added this to the v3.0.0-rc2 milestone Jun 16, 2021
Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest send a discuss mail to dev@dubbo.apache.org , in order to all developers know why will not support this feature in dubbo-go 3.0.

@LaurenceLiZhixin
Copy link
Contributor Author

Suggest send a discuss mail to dev@dubbo.apache.org , in order to all developers know why will not support this feature in dubbo-go 3.0.

由于近期要rc2发版,这次发版就先不删掉consul了,之后会尝试邮件投票的形式讨论。

@LaurenceLiZhixin LaurenceLiZhixin changed the title Fix: delete consul & dubbo-cli, update triple version Fix: delete dubbo-cli, update triple version Jun 16, 2021
@LaurenceLiZhixin LaurenceLiZhixin merged commit fc71917 into apache:3.0 Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants