Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make config center metadata configuable #1253

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

LaurenceLiZhixin
Copy link
Contributor

@LaurenceLiZhixin LaurenceLiZhixin commented Jun 11, 2021

What this PR does:

  1. Make BaseConfig struct configurable in config center
  2. Change "start metadata report " logic after config refresh from config-center

Which issue(s) this PR fixes:

Fixes #1213
user can set properties in config center to define metadata-report related configuration:

dubbo.remote.zk1.address=127.0.0.1:2181
dubbo.remote.zk1.timeout=5s
dubbo.metadata-report.protocol=zookeeper
dubbo.metadata-report.remote_ref=zk1
dubbo.service-discovery.zk-dis.protocol=zookeeper
dubbo.service-discovery.zk-dis.remote_ref=zk1

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

Codecov Report

Merging #1253 (9d78267) into 1.5 (a10ff4d) will decrease coverage by 7.49%.
The diff coverage is 61.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.5    #1253      +/-   ##
==========================================
- Coverage   66.13%   58.63%   -7.50%     
==========================================
  Files         174      273      +99     
  Lines        9343    13254    +3911     
==========================================
+ Hits         6179     7772    +1593     
- Misses       2541     4520    +1979     
- Partials      623      962     +339     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster_invoker.go 66.66% <ø> (-6.67%) ⬇️
cluster/cluster_impl/broadcast_cluster_invoker.go 76.47% <ø> (-3.53%) ⬇️
cluster/cluster_impl/failfast_cluster_invoker.go 66.66% <ø> (-4.77%) ⬇️
cluster/cluster_impl/mock_cluster.go 0.00% <0.00%> (ø)
cluster/loadbalance/random.go 100.00% <ø> (ø)
cluster/router/healthcheck/factory.go 66.66% <0.00%> (ø)
common/extension/auth.go 0.00% <ø> (ø)
common/extension/cluster.go 0.00% <ø> (ø)
common/extension/cluster_interceptor.go 0.00% <0.00%> (ø)
common/extension/config_center.go 0.00% <ø> (ø)
... and 388 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdae603...9d78267. Read the comment docs.

@AlexStocks AlexStocks merged commit a3569bf into apache:1.5 Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants