Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add listen routerChain when NewBaseDirectory #1250

Merged
merged 3 commits into from
Jun 14, 2021

Conversation

cjphaha
Copy link
Member

@cjphaha cjphaha commented Jun 8, 2021

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

when run NewBaseDirectory() start a new goroutine to run RouterChain Loop

@codecov-commenter
Copy link

Codecov Report

Merging #1250 (13b4fd7) into 1.5 (a10ff4d) will decrease coverage by 7.62%.
The diff coverage is 60.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.5    #1250      +/-   ##
==========================================
- Coverage   66.13%   58.50%   -7.63%     
==========================================
  Files         174      272      +98     
  Lines        9343    13251    +3908     
==========================================
+ Hits         6179     7753    +1574     
- Misses       2541     4536    +1995     
- Partials      623      962     +339     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster_invoker.go 66.66% <ø> (-6.67%) ⬇️
cluster/cluster_impl/broadcast_cluster_invoker.go 76.47% <ø> (-3.53%) ⬇️
cluster/cluster_impl/failfast_cluster_invoker.go 66.66% <ø> (-4.77%) ⬇️
cluster/cluster_impl/mock_cluster.go 0.00% <0.00%> (ø)
cluster/loadbalance/random.go 100.00% <ø> (ø)
cluster/router/healthcheck/factory.go 66.66% <0.00%> (ø)
common/extension/auth.go 0.00% <ø> (ø)
common/extension/cluster.go 0.00% <ø> (ø)
common/extension/cluster_interceptor.go 0.00% <0.00%> (ø)
common/extension/config_center.go 0.00% <ø> (ø)
... and 386 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37229e3...13b4fd7. Read the comment docs.

Copy link
Contributor

@zhaoyunxing92 zhaoyunxing92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved these changes

@AlexStocks AlexStocks merged commit 695ff65 into apache:1.5 Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants