-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
route call optimize #1244
route call optimize #1244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix conflicts pls
Codecov Report
@@ Coverage Diff @@
## 1.5 #1244 +/- ##
==========================================
- Coverage 58.93% 58.47% -0.47%
==========================================
Files 269 273 +4
Lines 13180 13267 +87
==========================================
- Hits 7768 7758 -10
- Misses 4437 4551 +114
+ Partials 975 958 -17
Continue to review full report at Codecov.
|
} | ||
// start to listen notify | ||
go dir.routerChain.Loop() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why will you delete this code? if you delete this code , router will not effect no longer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
因为baseDirectory在new的时候不需要创建routerChain,因为我没有创建任何路由策略,所不需要loop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved these changes
in
RegistryDirectory.List
If I didn't create the route it should just go back
cacheInvokers
,butNewRegistryDirectory
created a default routerChain struct, so the judgment here will never be valid