Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: as a path for pr 1225 #1233

Merged
merged 3 commits into from
Jun 8, 2021
Merged

Fix: as a path for pr 1225 #1233

merged 3 commits into from
Jun 8, 2021

Conversation

AlexStocks
Copy link
Contributor

What this PR does:

as a patch for pr #1225

Which issue(s) this PR fixes:

Fixes #1166

@AlexStocks AlexStocks changed the title Fix/1166 2 Fix: as a path for pr 1225 Jun 1, 2021
@AlexStocks AlexStocks changed the base branch from master to 1.5 June 1, 2021 14:46
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2021

Codecov Report

Merging #1233 (12261de) into 1.5 (a10ff4d) will decrease coverage by 7.49%.
The diff coverage is 60.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.5    #1233      +/-   ##
==========================================
- Coverage   66.13%   58.63%   -7.50%     
==========================================
  Files         174      272      +98     
  Lines        9343    13249    +3906     
==========================================
+ Hits         6179     7769    +1590     
- Misses       2541     4520    +1979     
- Partials      623      960     +337     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster_invoker.go 66.66% <ø> (-6.67%) ⬇️
cluster/cluster_impl/broadcast_cluster_invoker.go 76.47% <ø> (-3.53%) ⬇️
cluster/cluster_impl/failfast_cluster_invoker.go 66.66% <ø> (-4.77%) ⬇️
cluster/cluster_impl/mock_cluster.go 0.00% <0.00%> (ø)
cluster/loadbalance/random.go 100.00% <ø> (ø)
cluster/router/healthcheck/factory.go 66.66% <0.00%> (ø)
common/extension/auth.go 0.00% <ø> (ø)
common/extension/cluster.go 0.00% <ø> (ø)
common/extension/cluster_interceptor.go 0.00% <0.00%> (ø)
common/extension/config_center.go 0.00% <ø> (ø)
... and 386 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdae603...12261de. Read the comment docs.

@AlexStocks AlexStocks force-pushed the fix/1166-2 branch 2 times, most recently from f404c22 to eb6e261 Compare June 5, 2021 14:05
* fix dead lock

* Temporarily fix error occurred in getty unit test

* fix testClient_AsyncCall assertion bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when invoker refer check fail, service will be added in cache invokers fail
6 participants