Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

application service discovery support nacos reporter #1218

Merged
merged 8 commits into from
May 30, 2021
Merged

application service discovery support nacos reporter #1218

merged 8 commits into from
May 30, 2021

Conversation

ztelur
Copy link
Contributor

@ztelur ztelur commented May 26, 2021

What this PR does:

  • application service discovery support nacos reporter
  • reference_config ProvidedBy definition change

why change reference_config ProvidedBy definition:

  • there is a misspell, so I change it from "provide-by" to "provided_by" according to constant/key.PROVIDER_BY values and dubbo java param "provided-by".
  • dubbo-go-samples client.yaml is all wrong related to this param, so application service discovery will fail when client search server metadata info beacause the param is always empty.
  • the fact which registry/servicediscovery/zookeeper works successfully is coincident,because applicationName in client.yaml is same with applicationName in server.yaml and serviceDiscoveryRegistry.getServices function will return applicationName as default value when providerBy param is empty

Special notes for your reviewer:

  • dubbo-go-samples which contains nacos example and zookeeper conf yaml file changes will open a pull request after this merged

Copy link
Contributor

@hxmhlt hxmhlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

config/reference_config.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2021

Codecov Report

Merging #1218 (e49d7e2) into 3.0 (968650f) will decrease coverage by 3.62%.
The diff coverage is 50.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1218      +/-   ##
==========================================
- Coverage   59.53%   55.90%   -3.63%     
==========================================
  Files         259      272      +13     
  Lines       12737    12880     +143     
==========================================
- Hits         7583     7201     -382     
- Misses       4199     4782     +583     
+ Partials      955      897      -58     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster.go 100.00% <ø> (ø)
cluster/cluster_impl/available_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/broadcast_cluster.go 100.00% <ø> (ø)
cluster/cluster_impl/broadcast_cluster_invoker.go 76.47% <ø> (ø)
cluster/cluster_impl/failback_cluster.go 100.00% <ø> (ø)
cluster/cluster_impl/failfast_cluster.go 100.00% <ø> (ø)
cluster/cluster_impl/failfast_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/failover_cluster.go 100.00% <ø> (ø)
cluster/cluster_impl/failsafe_cluster.go 100.00% <ø> (ø)
cluster/cluster_impl/forking_cluster.go 100.00% <ø> (ø)
... and 275 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 547ec60...e49d7e2. Read the comment docs.

@AlexStocks AlexStocks merged commit d9ee29d into apache:3.0 May 30, 2021
@LaurenceLiZhixin LaurenceLiZhixin added this to the v3.0.0-rc2 milestone Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants