remove reflect in grpc server #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.0 #1200 +/- ##
==========================================
- Coverage 59.53% 56.04% -3.49%
==========================================
Files 259 269 +10
Lines 12737 12827 +90
==========================================
- Hits 7583 7189 -394
- Misses 4199 4741 +542
+ Partials 955 897 -58
Continue to review full report at Codecov.
|
zouyx
approved these changes
May 20, 2021
AlexStocks
approved these changes
May 20, 2021
hxmhlt
reviewed
May 28, 2021
| @@ -134,18 +136,12 @@ func waitGrpcExporter(providerServices map[string]*config.ServiceConfig) { | |||
| func registerService(providerServices map[string]*config.ServiceConfig, server *grpc.Server) { | |||
| for key, providerService := range providerServices { | |||
| service := config.GetProviderService(key) | |||
|
|
|||
| ds, ok := service.(DubboGrpcService) | |||
| if !ok { | |||
There was a problem hiding this comment.
service check exist: https://github.com/apache/dubbo-go/blob/master/config/config_loader.go#L259-L264.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
SetProxyImplin grpc serverDoes this PR introduce a user-facing change?: