Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid wg counter negative #118

Merged
merged 3 commits into from
Jul 3, 2019
Merged

avoid wg counter negative #118

merged 3 commits into from
Jul 3, 2019

Conversation

gaoxinge
Copy link

@gaoxinge gaoxinge commented Jul 3, 2019

What this PR does:

If we use client.Wait.Done in DataChange in the test, we may encounter the negative watigroup counter negative, because we invoke client.Wait.Add only once at

but invoke client.Wait.Done twice at

m.client.Wait.Done()

and

So just change client.Wait.Done into client.Close in DataChange, then we can handle this.

@codecov-io
Copy link

codecov-io commented Jul 3, 2019

Codecov Report

Merging #118 into master will decrease coverage by 0.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
- Coverage   68.02%   67.56%   -0.46%     
==========================================
  Files          69       69              
  Lines        4350     4350              
==========================================
- Hits         2959     2939      -20     
- Misses       1087     1111      +24     
+ Partials      304      300       -4
Impacted Files Coverage Δ
cluster/cluster_impl/base_cluster_invoker.go 48.93% <0%> (-19.15%) ⬇️
protocol/dubbo/listener.go 54.58% <0%> (-10.56%) ⬇️
protocol/dubbo/codec.go 68.57% <0%> (-8.58%) ⬇️
protocol/dubbo/readwriter.go 67.56% <0%> (-5.41%) ⬇️
protocol/dubbo/pool.go 56.98% <0%> (-5.03%) ⬇️
remoting/zookeeper/listener.go 48.64% <0%> (+4.86%) ⬆️
remoting/zookeeper/client.go 65.02% <0%> (+5.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1178d9a...8ddbea6. Read the comment docs.

@AlexStocks
Copy link
Contributor

@gaoxinge excellent work.

@AlexStocks AlexStocks merged commit a4078d1 into apache:master Jul 3, 2019
@gaoxinge gaoxinge deleted the fix branch July 3, 2019 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants