Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
If we use
client.Wait.Done
inDataChange
in the test, we may encounter thenegative watigroup counter negative
, because we invokeclient.Wait.Add
only once atdubbo-go/remoting/zookeeper/listener_test.go
Line 92 in 1178d9a
but invoke
client.Wait.Done
twice atdubbo-go/remoting/zookeeper/listener_test.go
Line 114 in 1178d9a
and
dubbo-go/remoting/zookeeper/client.go
Line 233 in 1178d9a
So just change
client.Wait.Done
intoclient.Close
inDataChange
, then we can handle this.