Fix: delete a service provider when using k8s hpa #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 2, 2021 20:39
# Conflicts: # remoting/nacos/builder.go # remoting/zookeeper/listener.go
Codecov Report
@@ Coverage Diff @@
## 1.5 #1154 +/- ##
==========================================
- Coverage 66.13% 58.93% -7.20%
==========================================
Files 174 269 +95
Lines 9343 13180 +3837
==========================================
+ Hits 6179 7768 +1589
- Misses 2541 4437 +1896
- Partials 623 975 +352
Continue to review full report at Codecov.
|
AlexStocks
approved these changes
Apr 14, 2021
wenxuwan
reviewed
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #1141
Special notes for your reviewer:
Does this PR introduce a user-facing change?: