Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: body buffer too short #1090

Merged
merged 12 commits into from
Mar 19, 2021
Merged

Fix: body buffer too short #1090

Changes from 4 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
45ca4f3
dubbo-go 拆包bug fix
Mar 17, 2021
6108ed0
Merge branch 'master' of https://github.com/xiejiajun/dubbo-go
Mar 17, 2021
57f7b4e
bug fix: getty RpcServerPackageHandler decode tcp pkg failed because …
Mar 18, 2021
160b834
keep error caller stack
Mar 18, 2021
80a24cb
code improve: use the `errors.Is()` to determine the type of err
Mar 18, 2021
40a9f7c
getty RpcServerPackageHandler decode incomplete tcp package unit test
Mar 18, 2021
8e18ffb
getty RpcServerPackageHandler decode incomplete tcp package unit test
Mar 18, 2021
da44eee
RpcClientPackageHandler error compare code improve
Mar 18, 2021
3afacb4
ut ci failed fix
Mar 18, 2021
0583f46
readwriter_test ci failed fix
Mar 18, 2021
51f6d0f
readwriter_test import code improve
Mar 19, 2021
c6a448b
code improve
Mar 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion remoting/getty/readwriter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,8 @@ func (p *RpcServerPackageHandler) Read(ss getty.Session, data []byte) (interface
req, length, err := (p.server.codec).Decode(data)
//resp,len, err := (*p.).DecodeResponse(buf)
if err != nil {
if err == hessian.ErrHeaderNotEnough || err == hessian.ErrBodyNotEnough {
originErr := perrors.Cause(err)
if originErr == hessian.ErrHeaderNotEnough || originErr == hessian.ErrBodyNotEnough {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using errors.Is() ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flycash please review

return nil, 0, nil
}

Expand Down