Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: fix zk listener func pathToKey #1066

Merged
merged 5 commits into from
Mar 10, 2021
Merged

Fix: fix zk listener func pathToKey #1066

merged 5 commits into from
Mar 10, 2021

Conversation

yakecanlee
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #1065

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

hxmhlt
hxmhlt reviewed Feb 26, 2021
View reviewed changes
Copy link
Contributor

@hxmhlt hxmhlt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(1)Please rename the variable groupKey to pathWithGroupKey, or combine line 80 & 81.
(2)Please check other config center implement in addtion to ZooKeepeer.

@yakecanlee
Copy link
Contributor Author

(1)Please rename the variable groupKey to pathWithGroupKey, or combine line 80 & 81.
(2)Please check other config center implement in addtion to ZooKeepeer.

done.

@AlexStocks AlexStocks added this to the v1.5.6-rc2 milestone Mar 6, 2021
beiwei30
beiwei30 approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlexStocks AlexStocks merged commit d12d342 into apache:1.5 Mar 10, 2021
AlexStocks added a commit that referenced this pull request Mar 11, 2021
@AlexStocks
Merge pull request #1066 from yakecanlee/feature/fix-zk-configurators
274718b 
Fix: fix zk listener func pathToKey
@yakecanlee yakecanlee deleted the feature/fix-zk-configurators branch March 19, 2021 02:35
AlexStocks added a commit that referenced this pull request Apr 14, 2021
@AlexStocks
Merge pull request #1066 from yakecanlee/feature/fix-zk-configurators
7037558 
Fix: fix zk listener func pathToKey
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beiwei30 beiwei30 beiwei30 approved these changes

@hxmhlt hxmhlt hxmhlt approved these changes

@AlexStocks AlexStocks AlexStocks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.6-rc2
Development

Successfully merging this pull request may close these issues.
4 participants
@yakecanlee @AlexStocks @hxmhlt @beiwei30