Ftr: registry ip:port set from enviroment variable #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurenceLiZhixin
changed the title
zouyx
reviewed
Feb 3, 2021
approve instead. |
gaoxinge
reviewed
Feb 5, 2021
gaoxinge
approved these changes
Feb 20, 2021
AlexStocks
approved these changes
Feb 23, 2021
AlexStocks
added a commit
that referenced
this pull request
Apr 14, 2021
Ftr: registry ip:port set from enviroment variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add support of "setting registry port and ip that read from environment".
I use this feature in design of docker example
In the docker environment example, registry ip and port should set by developer's defination, which is also dubbo-java does.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: