Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: support getty send Length, when the data transfer failed #1028

Merged
merged 4 commits into from
Feb 2, 2021

Conversation

cvictory
Copy link
Contributor

When the data is transfer failed and only transfered part of data, then the server can't decode the data.

So we should close the session.

@AlexStocks AlexStocks requested review from fangyincheng, zouyx and watermelo and removed request for fangyincheng January 30, 2021 09:36
@AlexStocks
Copy link
Contributor

pls change the target branch to 1.5

@cvictory cvictory changed the base branch from master to 1.5 February 2, 2021 03:36
@codecov-io
Copy link

Codecov Report

Merging #1028 (fdd545b) into 1.5 (968650f) will decrease coverage by 0.02%.
The diff coverage is 51.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.5    #1028      +/-   ##
==========================================
- Coverage   59.53%   59.50%   -0.03%     
==========================================
  Files         259      261       +2     
  Lines       12737    12973     +236     
==========================================
+ Hits         7583     7720     +137     
- Misses       4199     4272      +73     
- Partials      955      981      +26     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster.go 100.00% <ø> (ø)
cluster/cluster_impl/base_cluster_invoker.go 61.11% <0.00%> (-5.56%) ⬇️
cluster/router/condition/listenable_router.go 54.71% <0.00%> (ø)
cluster/router/healthcheck/health_check_route.go 70.37% <0.00%> (ø)
cluster/router/tag/router_rule.go 89.47% <ø> (+12.20%) ⬆️
cluster/router/tag/tag_router.go 72.59% <0.00%> (ø)
common/config/environment.go 51.72% <ø> (ø)
common/extension/config_post_processor.go 0.00% <0.00%> (ø)
common/extension/metadata_service.go 0.00% <0.00%> (ø)
common/proxy/proxy.go 90.19% <0.00%> (+0.87%) ⬆️
... and 150 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48de79c...fdd545b. Read the comment docs.

@AlexStocks AlexStocks added this to the v1.5.6 milestone Feb 2, 2021
@AlexStocks AlexStocks merged commit 0abac1d into apache:1.5 Feb 2, 2021
AlexStocks added a commit that referenced this pull request Apr 14, 2021
Fix: support getty send Length, when the data transfer failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants