Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: integration test in Github action #1012

Merged
merged 7 commits into from
Jan 24, 2021

Conversation

zouyx
Copy link
Member

@zouyx zouyx commented Jan 23, 2021

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@zouyx zouyx added the bug Something isn't working label Jan 23, 2021
@zouyx zouyx added this to the v1.5.6 milestone Jan 23, 2021
@AlexStocks AlexStocks force-pushed the develop branch 2 times, most recently from 25c3b98 to 9a666eb Compare January 23, 2021 11:12
@codecov-io
Copy link

Codecov Report

Merging #1012 (882930c) into develop (f354f90) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1012   +/-   ##
========================================
  Coverage    59.73%   59.73%           
========================================
  Files          261      261           
  Lines        12919    12923    +4     
========================================
+ Hits          7717     7720    +3     
- Misses        4228     4229    +1     
  Partials       974      974           
Impacted Files Coverage Δ
config_center/nacos/facade.go 79.31% <0.00%> (-10.35%) ⬇️
config_center/nacos/client.go 65.26% <0.00%> (-2.11%) ⬇️
registry/nacos/registry.go 50.36% <0.00%> (-0.77%) ⬇️
remoting/kubernetes/listener.go 50.52% <0.00%> (ø)
filter/filter_impl/sentinel_filter.go 63.04% <0.00%> (ø)
metadata/report/delegate/delegate_report.go 37.60% <0.00%> (+0.80%) ⬆️
remoting/kubernetes/watch.go 79.12% <0.00%> (+2.19%) ⬆️
remoting/kubernetes/client.go 75.00% <0.00%> (+2.94%) ⬆️
...tocol/rest/server/server_impl/go_restful_server.go 48.78% <0.00%> (+4.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f354f90...882930c. Read the comment docs.

@cityiron cityiron merged commit ec2a259 into apache:develop Jan 24, 2021
@zouyx zouyx deleted the feature/fixIntegrationTest branch January 26, 2021 13:44
AlexStocks pushed a commit that referenced this pull request Apr 14, 2021
Fix: integration test in Github action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants