-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/graceful shutdown #1007
Merged
AlexStocks
merged 10 commits into
apache:1.5
from
LaurenceLiZhixin:fix/gracefulShutdown
Feb 23, 2021
Merged
Fix/graceful shutdown #1007
AlexStocks
merged 10 commits into
apache:1.5
from
LaurenceLiZhixin:fix/gracefulShutdown
Feb 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
force-pushed
the
develop
branch
3 times, most recently
from
January 23, 2021 11:12
25c3b98
to
9a666eb
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1007 +/- ##
===========================================
+ Coverage 59.45% 59.49% +0.03%
===========================================
Files 261 261
Lines 12950 12950
===========================================
+ Hits 7700 7705 +5
+ Misses 4276 4271 -5
Partials 974 974
Continue to review full report at Codecov.
|
gaoxinge
approved these changes
Jan 26, 2021
AlexStocks
approved these changes
Jan 27, 2021
watermelo
approved these changes
Jan 28, 2021
zouyx
approved these changes
Jan 28, 2021
pls change the target branch to 1.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Change place of time.AfterFunc in graceful shutdown procedure.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Change place of time.AfterFunc in graceful shutdown procedure, to make it useful.
Add default graceful shutdown timout.
Does this PR introduce a user-facing change?: