Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/graceful shutdown #1007

Merged
merged 10 commits into from
Feb 23, 2021
Merged

Conversation

LaurenceLiZhixin
Copy link
Contributor

What this PR does:
Change place of time.AfterFunc in graceful shutdown procedure.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
Change place of time.AfterFunc in graceful shutdown procedure, to make it useful.
Add default graceful shutdown timout.
Does this PR introduce a user-facing change?:


@AlexStocks AlexStocks force-pushed the develop branch 3 times, most recently from 25c3b98 to 9a666eb Compare January 23, 2021 11:12
@codecov-io
Copy link

Codecov Report

Merging #1007 (04348d5) into develop (17c4a9e) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1007      +/-   ##
===========================================
+ Coverage    59.45%   59.49%   +0.03%     
===========================================
  Files          261      261              
  Lines        12950    12950              
===========================================
+ Hits          7700     7705       +5     
+ Misses        4276     4271       -5     
  Partials       974      974              
Impacted Files Coverage Δ
config/graceful_shutdown.go 54.28% <0.00%> (ø)
config_center/nacos/facade.go 79.31% <0.00%> (-10.35%) ⬇️
cluster/cluster_impl/failback_cluster_invoker.go 73.49% <0.00%> (-2.41%) ⬇️
config_center/nacos/client.go 65.26% <0.00%> (-2.11%) ⬇️
remoting/kubernetes/listener.go 50.52% <0.00%> (ø)
remoting/kubernetes/watch.go 79.12% <0.00%> (+2.19%) ⬆️
remoting/kubernetes/client.go 75.00% <0.00%> (+2.94%) ⬆️
...tocol/rest/server/server_impl/go_restful_server.go 48.78% <0.00%> (+4.87%) ⬆️
cluster/cluster_impl/base_cluster_invoker.go 61.11% <0.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17c4a9e...04348d5. Read the comment docs.

@zouyx zouyx added the improve Refactor or improve label Jan 28, 2021
@AlexStocks
Copy link
Contributor

pls change the target branch to 1.5

@LaurenceLiZhixin LaurenceLiZhixin changed the base branch from develop to 1.5 February 1, 2021 09:42
@AlexStocks AlexStocks merged commit e92358f into apache:1.5 Feb 23, 2021
@cityiron cityiron added this to the v1.5.7 milestone Feb 25, 2021
AlexStocks added a commit that referenced this pull request Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve Refactor or improve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants