Fix: closeErr == nil

apache · Sep 1, 2019 · aa5c160 · aa5c160
1 parent ff4f9b9
commit aa5c160
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/protocol/dubbo/pool.go b/protocol/dubbo/pool.go
@@ -300,7 +300,7 @@ func (p *gettyRPCClientPool) getGettyRpcClient(protocol, addr string) (*gettyRPC
 		p.conns = p.conns[:len(p.conns)-1]
 
 		if d := now - conn.getActive(); d > p.ttl {
-			if closeErr := conn.safeClose(); closeErr != nil {
+			if closeErr := conn.safeClose(); closeErr == nil {
 				p.remove(conn)
 			}
 			continue
@@ -331,7 +331,7 @@ func (p *gettyRPCClientPool) release(conn *gettyRPCClient, err error) {
 	}
 
 	if len(p.conns) >= p.size {
-		if closeErr := conn.safeClose(); closeErr != nil {
+		if closeErr := conn.safeClose(); closeErr == nil {
 			// delete @conn from client pool
 			p.remove(conn)
 		}