perf: avoid executing the loop when the log level is not debug

apache · Jun 3, 2023 · a3b32b2 · a3b32b2
1 parent 0d795bb
commit a3b32b2
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 9 deletions.
diff --git a/config/consumer_config.go b/config/consumer_config.go
@@ -67,11 +67,17 @@ func (cc *ConsumerConfig) Init(rc *RootConfig) error {
 		return nil
 	}
 
-	consumerNames := make([]string, 0, len(cc.References))
-	for k := range cc.References {
-		consumerNames = append(consumerNames, k)
+	buildDebugMsg := func() string {
+		if len(cc.References) == 0 {
+			return "empty"
+		}
+		consumerNames := make([]string, 0, len(cc.References))
+		for k := range cc.References {
+			consumerNames = append(consumerNames, k)
+		}
+		return strings.Join(consumerNames, ", ")
 	}
-	logger.Debugf("Registered consumer clients are %v", strings.Join(consumerNames, ", "))
+	logger.Debugf("Registered consumer clients are %v", buildDebugMsg())
 
 	cc.RegistryIDs = translateIds(cc.RegistryIDs)
 	if len(cc.RegistryIDs) <= 0 {

diff --git a/config/provider_config.go b/config/provider_config.go
@@ -76,12 +76,17 @@ func (c *ProviderConfig) Init(rc *RootConfig) error {
 	if c == nil {
 		return nil
 	}
-
-	providerNames := make([]string, 0, len(c.Services))
-	for k := range c.Services {
-		providerNames = append(providerNames, k)
+	buildDebugMsg := func() string {
+		if len(c.Services) == 0 {
+			return "empty"
+		}
+		providerNames := make([]string, 0, len(c.Services))
+		for k := range c.Services {
+			providerNames = append(providerNames, k)
+		}
+		return strings.Join(providerNames, ", ")
 	}
-	logger.Debugf("Registered provider services are %v", strings.Join(providerNames, ", "))
+	logger.Debugf("Registered provider services are %v", buildDebugMsg())
 
 	c.RegistryIDs = translateIds(c.RegistryIDs)
 	if len(c.RegistryIDs) <= 0 {