Skip to content

Commit

Permalink
[3.1] cherry-pick ioutil replace to release-3.1 (#2597)
Browse files Browse the repository at this point in the history
  • Loading branch information
dongjiang1989 authored Feb 20, 2024
1 parent 6dba60a commit 8f81c76
Show file tree
Hide file tree
Showing 17 changed files with 59 additions and 139 deletions.
16 changes: 4 additions & 12 deletions config/config_loader_options.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,26 +18,18 @@
package config

import (
"io/ioutil"
"os"
"path/filepath"
"runtime"
"strings"
)

import (
"dubbo.apache.org/dubbo-go/v3/common/constant"
"dubbo.apache.org/dubbo-go/v3/common/constant/file"
"github.com/dubbogo/gost/log/logger"

"github.com/knadh/koanf"

"github.com/pkg/errors"
)

import (
"dubbo.apache.org/dubbo-go/v3/common/constant"
"dubbo.apache.org/dubbo-go/v3/common/constant/file"
)

type loaderConf struct {
suffix string // loaderConf file extension default yaml
path string // loaderConf file path default ./conf/dubbogo.yaml
Expand Down Expand Up @@ -66,7 +58,7 @@ func NewLoaderConf(opts ...LoaderConfOption) *loaderConf {
return conf
}
if len(conf.bytes) <= 0 {
if bytes, err := ioutil.ReadFile(conf.path); err != nil {
if bytes, err := os.ReadFile(conf.path); err != nil {
panic(err)
} else {
conf.bytes = bytes
Expand Down Expand Up @@ -108,7 +100,7 @@ func WithSuffix(suffix file.Suffix) LoaderConfOption {
func WithPath(path string) LoaderConfOption {
return loaderConfigFunc(func(conf *loaderConf) {
conf.path = absolutePath(path)
if bytes, err := ioutil.ReadFile(conf.path); err != nil {
if bytes, err := os.ReadFile(conf.path); err != nil {
panic(err)
} else {
conf.bytes = bytes
Expand Down
8 changes: 3 additions & 5 deletions config/tls_config.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,8 @@ package config
import (
"crypto/tls"
"crypto/x509"
"io/ioutil"
)
"os"

import (
"dubbo.apache.org/dubbo-go/v3/common/constant"
)

Expand All @@ -50,7 +48,7 @@ func GetServerTlsConfig(opt *TLSConfig) (*tls.Config, error) {
//need mTLS
if opt.CACertFile != "" {
ca = x509.NewCertPool()
caBytes, err := ioutil.ReadFile(opt.CACertFile)
caBytes, err := os.ReadFile(opt.CACertFile)
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -80,7 +78,7 @@ func GetClientTlsConfig(opt *TLSConfig) (*tls.Config, error) {
ServerName: opt.TLSServerName,
}
ca := x509.NewCertPool()
caBytes, err := ioutil.ReadFile(opt.CACertFile)
caBytes, err := os.ReadFile(opt.CACertFile)
if err != nil {
return nil, err
}
Expand Down
14 changes: 4 additions & 10 deletions config_center/file/impl.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,25 +20,19 @@ package file
import (
"bytes"
"errors"
"io/ioutil"
"os"
"os/exec"
"os/user"
"path/filepath"
"runtime"
"strings"
)

import (
gxset "github.com/dubbogo/gost/container/set"

perrors "github.com/pkg/errors"
)

import (
"dubbo.apache.org/dubbo-go/v3/common"
"dubbo.apache.org/dubbo-go/v3/config_center"
"dubbo.apache.org/dubbo-go/v3/config_center/parser"
perrors "github.com/pkg/errors"
)

var osType = runtime.GOOS
Expand Down Expand Up @@ -132,7 +126,7 @@ func (fsdc *FileSystemDynamicConfiguration) GetProperties(key string, opts ...co
}

tmpPath := fsdc.GetPath(key, tmpOpts.Group)
file, err := ioutil.ReadFile(tmpPath)
file, err := os.ReadFile(tmpPath)
if err != nil {
return "", perrors.WithStack(err)
}
Expand Down Expand Up @@ -161,7 +155,7 @@ func (fsdc *FileSystemDynamicConfiguration) GetConfigKeysByGroup(group string) (
tmpPath := fsdc.GetPath("", group)
r := gxset.NewSet()

fileInfo, _ := ioutil.ReadDir(tmpPath)
fileInfo, _ := os.ReadDir(tmpPath)

for _, file := range fileInfo {
// list file
Expand Down Expand Up @@ -217,7 +211,7 @@ func (fsdc *FileSystemDynamicConfiguration) write2File(fp string, value string)
return perrors.WithStack(err)
}

return ioutil.WriteFile(fp, []byte(value), os.ModePerm)
return os.WriteFile(fp, []byte(value), os.ModePerm)
}

func forceMkdirParent(fp string) error {
Expand Down
14 changes: 4 additions & 10 deletions config_center/file/listener.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,20 +18,14 @@
package file

import (
"io/ioutil"
"os"
"sync"
)

import (
"github.com/dubbogo/gost/log/logger"

"github.com/fsnotify/fsnotify"
)

import (
"dubbo.apache.org/dubbo-go/v3/common/extension"
"dubbo.apache.org/dubbo-go/v3/config_center"
"dubbo.apache.org/dubbo-go/v3/remoting"
"github.com/dubbogo/gost/log/logger"
"github.com/fsnotify/fsnotify"
)

// CacheListener is file watcher
Expand Down Expand Up @@ -154,7 +148,7 @@ func (cl *CacheListener) RemoveListener(key string, listener config_center.Confi
}

func getFileContent(path string) string {
c, err := ioutil.ReadFile(path)
c, err := os.ReadFile(path)
if err != nil {
logger.Errorf("read file path:%s err:%v", path, err)
return ""
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module dubbo.apache.org/dubbo-go/v3

go 1.15
go 1.16

require (
cloud.google.com/go/compute/metadata v0.2.3 // indirect
Expand Down
9 changes: 0 additions & 9 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,6 @@ github.com/census-instrumentation/opencensus-proto v0.2.1/go.mod h1:f6KPmirojxKA
github.com/census-instrumentation/opencensus-proto v0.3.0/go.mod h1:f6KPmirojxKA12rnyqOA5BBL4O983OfeGPqjHWSTneU=
github.com/census-instrumentation/opencensus-proto v0.4.1 h1:iKLQ0xPNFxR/2hzXZMrBo8f1j86j5WHzznCCQxV/b8g=
github.com/census-instrumentation/opencensus-proto v0.4.1/go.mod h1:4T9NM4+4Vw91VeyqjLS6ao50K5bOcLKN6Q42XnYaRYw=
github.com/certifi/gocertifi v0.0.0-20191021191039-0944d244cd40 h1:xvUo53O5MRZhVMJAxWCJcS5HHrqAiAG9SJ1LpMu6aAI=
github.com/certifi/gocertifi v0.0.0-20191021191039-0944d244cd40/go.mod h1:sGbDF6GwGcLpkNXPUTkMRoywsNa/ol15pxFe6ERfguA=
github.com/cespare/xxhash v1.1.0 h1:a6HrQnmkObjyL+Gs60czilIUGqrzKutQD6XZog3p+ko=
github.com/cespare/xxhash v1.1.0/go.mod h1:XrSqR1VqqWfGrhpAt58auRo0WTKS1nRRg3ghfAqPWnc=
Expand Down Expand Up @@ -500,11 +499,8 @@ github.com/cncf/xds/go v0.0.0-20220314180256-7f1daf1720fc/go.mod h1:eXthEFrGJvWH
github.com/cncf/xds/go v0.0.0-20230310173818-32f1caf87195 h1:58f1tJ1ra+zFINPlwLWvQsR9CzAKt2e+EWV2yX9oXQ4=
github.com/cncf/xds/go v0.0.0-20230310173818-32f1caf87195/go.mod h1:eXthEFrGJvWHgFFCl3hGmgk+/aYT6PnTQLykKQRLhEs=
github.com/cockroachdb/datadriven v0.0.0-20190809214429-80d97fb3cbaa/go.mod h1:zn76sxSg3SzpJ0PPJaLDCu+Bu0Lg3sKTORVIj19EIF8=
github.com/cockroachdb/datadriven v0.0.0-20200714090401-bf6692d28da5 h1:xD/lrqdvwsc+O2bjSSi3YqY73Ke3LAiSCx49aCesA0E=
github.com/cockroachdb/datadriven v0.0.0-20200714090401-bf6692d28da5/go.mod h1:h6jFvWxBdQXxjopDMZyH2UVceIRfR84bdzbkoKrsWNo=
github.com/cockroachdb/errors v1.2.4 h1:Lap807SXTH5tri2TivECb/4abUkMZC9zRoLarvcKDqs=
github.com/cockroachdb/errors v1.2.4/go.mod h1:rQD95gz6FARkaKkQXUksEje/d9a6wBJoCr5oaCLELYA=
github.com/cockroachdb/logtags v0.0.0-20190617123548-eb05cc24525f h1:o/kfcElHqOiXqcou5a3rIlMc7oJbMQkeLk0VQJ7zgqY=
github.com/cockroachdb/logtags v0.0.0-20190617123548-eb05cc24525f/go.mod h1:i/u985jwjWRlyHXQbwatDASoW0RMlZ/3i9yJHE2xLkI=
github.com/codahale/hdrhistogram v0.0.0-20161010025455-3a0bb77429bd/go.mod h1:sE/e/2PUdi/liOCUjSTXgM1o87ZssimdTWN964YiIeI=
github.com/coreos/bbolt v1.3.2/go.mod h1:iRUV2dpdMOn7Bo10OQBFzIJO9kkE559Wcmn+qkEiiKk=
Expand Down Expand Up @@ -599,7 +595,6 @@ github.com/fsnotify/fsnotify v1.4.7/go.mod h1:jwhsz4b93w/PPRr/qN1Yymfu8t87LnFCMo
github.com/fsnotify/fsnotify v1.4.9/go.mod h1:znqG4EE+3YCdAaPaxE2ZRY/06pZUdp0tY4IgpuI1SZQ=
github.com/fsnotify/fsnotify v1.6.0 h1:n+5WquG0fcWoWp6xPWfHdbskMCQaFnG6PfBrh1Ky4HY=
github.com/fsnotify/fsnotify v1.6.0/go.mod h1:sl3t1tCWJFWoRz9R8WJCbQihKKwmorjAbSClcnxKAGw=
github.com/getsentry/raven-go v0.2.0 h1:no+xWJRb5ZI7eE8TWgIq1jLulQiIoLG0IfYxv5JYMGs=
github.com/getsentry/raven-go v0.2.0/go.mod h1:KungGk8q33+aIAZUIVWZDr2OfAEBsO49PX4NzFV5kcQ=
github.com/ghodss/yaml v1.0.0/go.mod h1:4dBDuWmgqj2HViK6kFavaiC9ZROes6MMH2rRYeMEF04=
github.com/go-asn1-ber/asn1-ber v1.3.1/go.mod h1:hEBeB/ic+5LoWskz+yKT7vGhhPYkProFKoKdwZRWMe0=
Expand Down Expand Up @@ -1380,7 +1375,6 @@ golang.org/x/lint v0.0.0-20191125180803-fdd1cda4f05f/go.mod h1:5qLYkcX4OjUUV8bRu
golang.org/x/lint v0.0.0-20200130185559-910be7a94367/go.mod h1:3xt1FjdF8hUf6vQPIChWIBhFzV8gjjsPE/fR3IyQdNY=
golang.org/x/lint v0.0.0-20200302205851-738671d3881b/go.mod h1:3xt1FjdF8hUf6vQPIChWIBhFzV8gjjsPE/fR3IyQdNY=
golang.org/x/lint v0.0.0-20201208152925-83fdc39ff7b5/go.mod h1:3xt1FjdF8hUf6vQPIChWIBhFzV8gjjsPE/fR3IyQdNY=
golang.org/x/lint v0.0.0-20210508222113-6edffad5e616 h1:VLliZ0d+/avPrXXH+OakdXhpJuEoBZuwh1m2j7U6Iug=
golang.org/x/lint v0.0.0-20210508222113-6edffad5e616/go.mod h1:3xt1FjdF8hUf6vQPIChWIBhFzV8gjjsPE/fR3IyQdNY=
golang.org/x/mobile v0.0.0-20190312151609-d3739f865fa6/go.mod h1:z+o9i4GpDbdi3rU15maQ/Ox0txvL9dWGYEHz965HBQE=
golang.org/x/mobile v0.0.0-20190719004257-d2bd2a29d028/go.mod h1:E/iHnbuqvinMTCcRqshq8CkpyQDoeVncDDYHnLhea+o=
Expand All @@ -1396,7 +1390,6 @@ golang.org/x/mod v0.4.2/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
golang.org/x/mod v0.6.0-dev.0.20220419223038-86c51ed26bb4/go.mod h1:jJ57K6gSWd91VN4djpZkiMVwK6gcyfeH4XE8wZrZaV4=
golang.org/x/mod v0.7.0/go.mod h1:iBbtSCu2XBx23ZKBPSOrRkjjQPZFPuis4dIYUhu/chs=
golang.org/x/mod v0.8.0/go.mod h1:iBbtSCu2XBx23ZKBPSOrRkjjQPZFPuis4dIYUhu/chs=
golang.org/x/mod v0.9.0 h1:KENHtAZL2y3NLMYZeHY9DW8HW8V+kQyJsY/V9JlKvCs=
golang.org/x/mod v0.9.0/go.mod h1:iBbtSCu2XBx23ZKBPSOrRkjjQPZFPuis4dIYUhu/chs=
golang.org/x/net v0.0.0-20180530234432-1e491301e022/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
golang.org/x/net v0.0.0-20180724234803-3673e40ba225/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
Expand Down Expand Up @@ -1728,7 +1721,6 @@ golang.org/x/tools v0.1.5/go.mod h1:o0xws9oXOQQZyjljx8fwUC0k7L1pTE6eaCbjGeHmOkk=
golang.org/x/tools v0.1.12/go.mod h1:hNGJHUnrk76NpqgfD5Aqm5Crs+Hm0VOH/i9J2+nxYbc=
golang.org/x/tools v0.3.0/go.mod h1:/rWhSS2+zyEVwoJf8YAX6L2f0ntZ7Kn/mGgAWcipA5k=
golang.org/x/tools v0.6.0/go.mod h1:Xwgl3UAJ/d3gWutnCtw505GrjyAbvKui8lOU390QaIU=
golang.org/x/tools v0.7.0 h1:W4OVu8VVOaIO0yzWMNdepAulS7YfoS3Zabrm8DOXXU4=
golang.org/x/tools v0.7.0/go.mod h1:4pg6aUX35JBAogB10C9AtvVL+qowtN4pT3CGSQex14s=
golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
Expand All @@ -1743,7 +1735,6 @@ gonum.org/v1/gonum v0.0.0-20181121035319-3f7ecaa7e8ca/go.mod h1:Y+Yx5eoAFn32cQvJ
gonum.org/v1/gonum v0.8.2 h1:CCXrcPKiGGotvnN6jfUsKk4rRqm7q09/YbKb5xCEvtM=
gonum.org/v1/gonum v0.8.2/go.mod h1:oe/vMfY3deqTw+1EZJhuvEW2iwGF1bW9wwu7XCu0+v0=
gonum.org/v1/netlib v0.0.0-20181029234149-ec6d1f5cefe6/go.mod h1:wa6Ws7BG/ESfp6dHfk7C6KdzKA7wR7u/rKwOGE66zvw=
gonum.org/v1/netlib v0.0.0-20190313105609-8cb42192e0e0 h1:OE9mWmgKkjJyEmDAAtGMPjXu+YNeGvK9VTSHY6+Qihc=
gonum.org/v1/netlib v0.0.0-20190313105609-8cb42192e0e0/go.mod h1:wa6Ws7BG/ESfp6dHfk7C6KdzKA7wR7u/rKwOGE66zvw=
gonum.org/v1/plot v0.0.0-20190515093506-e2840ee46a6b/go.mod h1:Wt8AAjI+ypCyYX3nZBvf6cAIx93T+c/OS2HFAYskSZc=
google.golang.org/api v0.3.1/go.mod h1:6wY9I6uQWHQ8EM57III9mq/AjF+i8G65rmVagqKMtkk=
Expand Down
11 changes: 3 additions & 8 deletions protocol/dubbo3/reflection/serverreflection.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,24 +28,19 @@ import (
"compress/gzip"
"fmt"
"io"
"io/ioutil"
"reflect"
"sort"
"strings"
"sync"
)

import (
"github.com/dubbogo/grpc-go"
"github.com/dubbogo/grpc-go/codes"
"github.com/dubbogo/grpc-go/status"

"github.com/golang/protobuf/proto"
dpb "github.com/golang/protobuf/protoc-gen-go/descriptor"
)

import (
"dubbo.apache.org/dubbo-go/v3/config"
dpb "github.com/golang/protobuf/protoc-gen-go/descriptor"

rpb "dubbo.apache.org/dubbo-go/v3/protocol/dubbo3/reflection/triple_reflection_v1alpha"
)

Expand Down Expand Up @@ -219,7 +214,7 @@ func decompress(b []byte) ([]byte, error) {
if err != nil {
return nil, fmt.Errorf("bad gzipped descriptor: %v", err)
}
out, err := ioutil.ReadAll(r)
out, err := io.ReadAll(r)
if err != nil {
return nil, fmt.Errorf("bad gzipped descriptor: %v", err)
}
Expand Down
12 changes: 3 additions & 9 deletions protocol/jsonrpc/http.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,27 +22,21 @@ import (
"bytes"
"context"
"fmt"
"io/ioutil"
"io"
"net"
"net/http"
"net/url"
"os"
"strings"
"sync/atomic"
"time"
)

import (
"github.com/dubbogo/gost/log/logger"

"github.com/opentracing/opentracing-go"

perrors "github.com/pkg/errors"
)

import (
"dubbo.apache.org/dubbo-go/v3/common"
"dubbo.apache.org/dubbo-go/v3/common/constant"
perrors "github.com/pkg/errors"
)

// Request is HTTP protocol request
Expand Down Expand Up @@ -194,7 +188,7 @@ func (c *HTTPClient) Do(addr, path string, httpHeader http.Header, body []byte)
}
defer httpRsp.Body.Close()

b, err := ioutil.ReadAll(httpRsp.Body)
b, err := io.ReadAll(httpRsp.Body)
if err != nil {
return nil, perrors.WithStack(err)
}
Expand Down
17 changes: 5 additions & 12 deletions protocol/jsonrpc/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,27 +22,20 @@ import (
"bytes"
"context"
"io"
"io/ioutil"
"net"
"net/http"
"runtime"
"runtime/debug"
"sync"
"time"
)

import (
"github.com/dubbogo/gost/log/logger"

"github.com/opentracing/opentracing-go"

perrors "github.com/pkg/errors"
)

import (
"dubbo.apache.org/dubbo-go/v3/common"
"dubbo.apache.org/dubbo-go/v3/common/constant"
"dubbo.apache.org/dubbo-go/v3/protocol/invocation"
perrors "github.com/pkg/errors"
)

// A value sent as a placeholder for the server's response value when the server
Expand Down Expand Up @@ -106,7 +99,7 @@ func (s *Server) handlePkg(conn net.Conn) {
ProtoMajor: 1,
ProtoMinor: 1,
ContentLength: int64(len(body)),
Body: ioutil.NopCloser(bytes.NewReader(body)),
Body: io.NopCloser(bytes.NewReader(body)),
}
rsp.Header.Del("Content-Type")
rsp.Header.Del("Content-Length")
Expand All @@ -130,7 +123,7 @@ func (s *Server) handlePkg(conn net.Conn) {
return
}

reqBody, err := ioutil.ReadAll(r.Body)
reqBody, err := io.ReadAll(r.Body)
r.Body.Close()
if err != nil {
return
Expand Down Expand Up @@ -277,7 +270,7 @@ func serveRequest(ctx context.Context, header map[string]string, body []byte, co
ProtoMajor: 1,
ProtoMinor: 1,
ContentLength: int64(len(body)),
Body: ioutil.NopCloser(bytes.NewReader(body)),
Body: io.NopCloser(bytes.NewReader(body)),
}
rsp.Header.Del("Content-Type")
rsp.Header.Del("Content-Length")
Expand All @@ -303,7 +296,7 @@ func serveRequest(ctx context.Context, header map[string]string, body []byte, co
ProtoMajor: 1,
ProtoMinor: 1,
ContentLength: int64(len(body)),
Body: ioutil.NopCloser(bytes.NewReader(body)),
Body: io.NopCloser(bytes.NewReader(body)),
}
rsp.Header.Del("Content-Type")
rsp.Header.Del("Content-Length")
Expand Down
Loading

0 comments on commit 8f81c76

Please sign in to comment.