Merge pull request #1829 from Lvnszn/fix/getty-eof

fix: fix unit test
apache · Apr 15, 2022 · 0f77532 · 0f77532
2 parents b4558b6 + 5ecfd19
commit 0f77532
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/protocol/dubbo/impl/codec.go b/protocol/dubbo/impl/codec.go
@@ -157,7 +157,7 @@ func (c *ProtocolCodec) Decode(p *DubboPackage) error {
 			return err
 		}
 	}
-	if c.reader.Size() < p.GetBodyLen() {
+	if c.reader.Size() < p.GetBodyLen()+HEADER_LENGTH {
 		return hessian.ErrBodyNotEnough
 	}
 	body, err := c.reader.Peek(p.GetBodyLen())

diff --git a/remoting/getty/readwriter_test.go b/remoting/getty/readwriter_test.go
@@ -75,8 +75,8 @@ func testDecodeTCPPackage(t *testing.T, svr *Server, client *Client) {
 	assert.True(t, incompletePkgLen >= impl.HEADER_LENGTH, "header buffer too short")
 	incompletePkg := pkgBytes[0 : incompletePkgLen-1]
 	pkg, pkgLen, err := pkgReadHandler.Read(nil, incompletePkg)
-	assert.NoError(t, err)
-	assert.Equal(t, pkg, nil)
+	assert.Equal(t, err.Error(), "body buffer too short")
+	assert.Equal(t, pkg.(*remoting.DecodeResult).Result, nil)
 	assert.Equal(t, pkgLen, 0)
 }