Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug: support java enum variable list #330

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

shenchao861129
Copy link
Contributor

What this PR does:

fix java enum variable list decoding bug

Which issue(s) this PR fixes:

Fixes #325

@codecov-commenter
Copy link

Codecov Report

Merging #330 (c1adabb) into master (e13beea) will increase coverage by 1.65%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
+ Coverage   70.50%   72.15%   +1.65%     
==========================================
  Files          27       27              
  Lines        3129     3128       -1     
==========================================
+ Hits         2206     2257      +51     
+ Misses        688      634      -54     
- Partials      235      237       +2     
Impacted Files Coverage Δ
list.go 85.58% <ø> (-0.13%) ⬇️
object.go 69.45% <100.00%> (+3.77%) ⬆️
codec.go 72.05% <0.00%> (-0.88%) ⬇️
pojo.go 82.45% <0.00%> (+17.10%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@wongoo wongoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wongoo wongoo merged commit 0db9c6b into apache:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

完善对Java枚举类型可变长参数方法的支持
4 participants