Skip to content

Conversation

@robocanic
Copy link
Contributor

Please provide a description of this PR:
Using client-go to do list-watch to kubernetes and transformed the pod into admin RuntimeInstanceResourrce, during the event processing, complete the linkage update of the InstanceResource

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Docs
  • Installation
  • User Experience
  • Dubboctl
  • Console
  • Core Component

Please check any characteristics that apply to this pull request.

@robocanic robocanic requested a review from Copilot October 21, 2025 00:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Kubernetes as a backend engine for Dubbo Admin, enabling pod-to-instance resource mapping through client-go's list-watch mechanism. The implementation transforms Kubernetes pods into RuntimeInstanceResources and maintains InstanceResource linkage via event-driven updates.

Key Changes

  • Introduced Kubernetes engine with pod list-watcher that transforms pods to RuntimeInstanceResources
  • Implemented event subscriber pattern to sync RuntimeInstance changes with Instance resources
  • Refactored component ordering system and runtime startup to support concurrent component execution

Reviewed Changes

Copilot reviewed 48 out of 48 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
pkg/engine/kubernetes/factory.go New factory for creating Kubernetes list-watchers with kubeconfig support
pkg/engine/kubernetes/engine.go Pod list-watcher implementation with transformation logic for RuntimeInstance
pkg/core/engine/subscriber/runtime_instance.go Event subscriber that syncs RuntimeInstance to Instance resources
pkg/core/engine/component.go Enhanced engine component with subscriber initialization
pkg/core/events/eventbus.go Refactored subscription to use Subscriber interface
pkg/core/runtime/runtime.go Changed component startup to concurrent execution with reversed ordering
pkg/config/engine/config.go Extended configuration with Kubernetes-specific properties
api/mesh/v1alpha1/runtime_instance.proto Enhanced RuntimeInstance with workload, node, probe, and condition fields

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@robocanic robocanic requested a review from Copilot October 21, 2025 01:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 51 out of 51 changed files in this pull request and generated 7 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@robocanic robocanic requested a review from AlexStocks October 21, 2025 01:17
@robocanic robocanic requested a review from Copilot October 21, 2025 14:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 51 out of 51 changed files in this pull request and generated 7 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2025

@AlexStocks AlexStocks merged commit ca9fb03 into apache:develop Nov 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants