Adding LinearShardSpec and ACL on S3 object #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * User: jbae | ||
| * Date: 2/4/13 | ||
| * Time: 10:22 AM | ||
| * To change this template use File | Settings | File Templates. |
There was a problem hiding this comment.
This text at the top of a class doesn't really add anything as far as documentation is concerned. Can you go into your IntelliJ File -> Settings -> File Templates and remove it?
cheddar
added a commit
that referenced
this pull request
Feb 11, 2013
Adding LinearShardSpec and ACL on S3 object
jon-wei
pushed a commit
to jon-wei/druid
that referenced
this pull request
Jun 23, 2020
…apache#9630) (apache#77) * check paths used for shuffle intermediary data manager get and delete * add test * newline * meh
abhishekagarwal87
referenced
this pull request
in abhishekagarwal87/druid
Dec 14, 2020
* OIDC authentication using Keycloak * clean up pom files; rename packages * javadocs * Revert "clean up pom files; rename packages" This reverts commit be2894eea2b79e0e79f52e2076d17545c3e491d3. * rename package and clean up pom * fix license headers * add readme * hopefully this makes ci happy * Fix checkstyle and add more tests * missing dependencies * Remove unused dependency and clean up commented out codes * fix typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added LinearShardingSpec under shard package and LinearPartitionChunk under partition package. This is a little different from SingleDimensionShardSpec. LinearShardSpec is necessary for increasing and decreasing druid realtime cluster size dynamically on demand. Meanwhile, SingleDimensionShardSpec requires predefined the number of shards.
I want to add REST_CANNED_BUCKET_OWNER_FULL_CONTROL to the s3 object. I know this might be very specific request in Netflix environment. The problem is, in eu-west-1 AWS, the account of druid ec2 instance is different from the account managing s3 bucket. So, without this ACL, lifecycle rule of s3 bucket is not being applied in eu-west-1. Also, you may know I cannot override the ACL out of druid core context.