Repository navigation
fix: correct JSON serialization of CloneQueryMode - #20557
Merged
FrankChen021 merged 1 commit intoOct 13, 2026
Merged
Conversation
FrankChen021
added a commit
to FrankChen021/druid
that referenced
this pull request
Oct 11, 2026
… form Also fixes CloneQueryMode's JSON serialization, which the check catches (same change as apache#20557).
FrankChen021
added a commit
to FrankChen021/druid
that referenced
this pull request
Oct 11, 2026
… form Also fixes CloneQueryMode's JSON serialization, which the check catches (same change as apache#20557).
FrankChen021
added a commit
to FrankChen021/druid
that referenced
this pull request
Oct 12, 2026
… form Also fixes CloneQueryMode's JSON serialization, which the check catches (same change as apache#20557).
FrankChen021
added a commit
to FrankChen021/druid
that referenced
this pull request
Oct 12, 2026
… form Also fixes CloneQueryMode's JSON serialization, which the check catches (same change as apache#20557).
FrankChen021
added a commit
to FrankChen021/druid
that referenced
this pull request
Oct 12, 2026
… form Also fixes CloneQueryMode's JSON serialization, which the check catches (same change as apache#20557).
FrankChen021
added a commit
to FrankChen021/druid
that referenced
this pull request
Oct 12, 2026
… form Also fixes CloneQueryMode's JSON serialization, which the check catches (same change as apache#20557).
FrankChen021
added a commit
to FrankChen021/druid
that referenced
this pull request
Oct 12, 2026
… form Also fixes CloneQueryMode's JSON serialization, which the check catches (same change as apache#20557).
FrankChen021
added a commit
to FrankChen021/druid
that referenced
this pull request
Oct 12, 2026
… form Also fixes CloneQueryMode's JSON serialization, which the check catches (same change as apache#20557).
FrankChen021
added a commit
to FrankChen021/druid
that referenced
this pull request
Oct 12, 2026
… form Also fixes CloneQueryMode's JSON serialization, which the check catches (same change as apache#20557).
3 tasks done
FrankChen021
commented
Oct 12, 2026
FrankChen021
left a comment
FrankChen021
left a comment
Member
Author
There was a problem hiding this comment.
🟢 Approval recommended
No actionable issues found. The new @JsonValue annotation aligns Jackson serialization with the existing @JsonCreator and documented lower-camel values; query-context parsing remains unaffected.
Reviewed 2 of 2 changed files.
Validation: git diff --check bb50f29b1d792c7b82e48dd24435be5966e8b269...810bc194ba7aa93676f8b920f3d1501d767cfe92 passed. No tests or builds were run.
This is an automated review by Codex GPT-5.6-Luna(max)
GWphua
approved these changes
Oct 13, 2026
FrankChen021
added a commit
to FrankChen021/druid
that referenced
this pull request
Oct 13, 2026
… form Also fixes CloneQueryMode's JSON serialization, which the check catches (same change as apache#20557).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CloneQueryModeserializes as its constant name (PREFERCLONES), but its@JsonCreatoronly acceptspreferClones, so a serialized value can't be read back. This annotatestoString()with@JsonValueso both directions usepreferClones.Query context reads are unaffected, since they parse the string case-insensitively.
This PR has: