-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run JDK 21 workflows with latest JDK. #17694
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts PR apache#17458.
clintropolis
approved these changes
Feb 3, 2025
JDK21 processing tests passed (yay). I re-ran them to be sure. |
I've just seen this: https://github.com/apache/druid/actions/runs/13161729196/job/36736492139?pr=17699 seems like the issue is still present; we should probably revert this. console log snipplet
|
cryptoe
added a commit
to cryptoe/druid
that referenced
this pull request
Mar 17, 2025
This reverts commit 31ede5c
cryptoe
added a commit
that referenced
this pull request
Mar 18, 2025
cecemei
pushed a commit
to cecemei/druid
that referenced
this pull request
Mar 31, 2025
…#17806) * Revert "Run JDK 21 workflows with latest JDK. (apache#17694)" This reverts commit 31ede5c * Review comments. * Review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts PR #17458. There's a new JDK out (21.0.6). Hopefully it does not segfault.