Cleanup unreachable Java 8 code flows #17559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
reviewed
Dec 12, 2024
| ClassLoader parent; | ||
| try { | ||
| // See also https://docs.oracle.com/en/java/javase/11/migrate/index.html#JSMIG-GUID-A868D0B9-026F-4D46-B979-901834343F9E | ||
| parent = (ClassLoader) ClassLoader.class.getMethod("getPlatformClassLoader").invoke(null); |
There was a problem hiding this comment.
no need to use reflection anymore
There was a problem hiding this comment.
Have made the change.
As discussed offline, the animal-sniffer check was causing failures since it's currently configured to use JDK8 signature, and upgrading animal-sniffer can be a separate follow-up item after this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a follow-up to #17466, some Java 8 specific flows are unreachable now.
This PR cleans such code flows, majorly the flows corresponding to
JvmUtils.isIsJava9Compatible()beingfalse.This PR has: