Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align ScanQuery column order with its desired signature #17457

Closed
wants to merge 22 commits into from

Conversation

kgyrtkirk
Copy link
Member

ScanQuery reorders its output columns to be in alphabetical ordering; this is not necessary - and depending on the names of the columns it may be different.

This is needed for UnionQuery to avoid incorrect results

Main change is a single line alteration in DruidQuery to use a LinkedHashSet instead of TreeMap.

@github-actions github-actions bot added Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Nov 7, 2024
@kgyrtkirk kgyrtkirk marked this pull request as ready for review November 7, 2024 23:15
cryptoe pushed a commit that referenced this pull request Nov 12, 2024
* ScanQuery: equals/hashCode/toString
* DruidQuery: changes of Align ScanQuery column order with its desired signature #17457
* ScanQueryTest: add equalsverifer test
@cryptoe
Copy link
Contributor

cryptoe commented Nov 12, 2024

Closed in favour of #17463

@cryptoe cryptoe closed this Nov 12, 2024
jtuglu-netflix pushed a commit to jtuglu-netflix/druid that referenced this pull request Nov 20, 2024
)

* ScanQuery: equals/hashCode/toString
* DruidQuery: changes of Align ScanQuery column order with its desired signature apache#17457
* ScanQueryTest: add equalsverifer test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 Area - Querying
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants