Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abstract common base of SQL micro-benchmarks to reduce boilerplate and standardize parameters #17383

Merged
merged 3 commits into from
Oct 23, 2024
Merged

abstract common base of SQL micro-benchmarks to reduce boilerplate and standardize parameters #17383

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d3411f
abstract common base of SQL micro-benchmarks to reduce boilerplate an…
clintropolis Oct 19, 2024
04d7f4d
adjustment
clintropolis Oct 19, 2024
df8f5fb
style
clintropolis Oct 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
adjustment
  • Loading branch information
@clintropolis
clintropolis committed Oct 19, 2024
commit 04d7f4db26e7dac981139561da5e72a6ad1a0ce3
22 changes: 11 additions & 11 deletions benchmarks/src/test/java/org/apache/druid/benchmark/query/SqlBaseBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,17 @@ private void checkIncompatibleParameters()
System.exit(0);
}
}

private StringEncodingStrategy getStringEncodingStrategy()
{
if (stringEncoding == BenchmarkStringEncodingStrategy.FRONT_CODED_DEFAULT_V1) {
return new StringEncodingStrategy.FrontCoded(null, FrontCodedIndexed.V1);
} else if (stringEncoding == BenchmarkStringEncodingStrategy.FRONT_CODED_16_V1) {
return new StringEncodingStrategy.FrontCoded(16, FrontCodedIndexed.V1);
} else {
return new StringEncodingStrategy.Utf8();
}
}

public static Pair<PlannerFactory, SqlEngine> createSqlSystem(
final Map<DataSegment, QueryableIndex> segmentMap,
Expand Down Expand Up @@ -540,17 +551,6 @@ private static DruidOperatorTable createOperatorTable(final Injector injector)
}
}

private StringEncodingStrategy getStringEncodingStrategy()
{
if (stringEncoding == BenchmarkStringEncodingStrategy.FRONT_CODED_DEFAULT_V1) {
return new StringEncodingStrategy.FrontCoded(null, FrontCodedIndexed.V1);
} else if (stringEncoding == BenchmarkStringEncodingStrategy.FRONT_CODED_16_V1) {
return new StringEncodingStrategy.FrontCoded(16, FrontCodedIndexed.V1);
} else {
return new StringEncodingStrategy.Utf8();
}
}

@TearDown(Level.Trial)
public void tearDown() throws Exception
{
Expand Down