Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing pip installation after ubuntu upgrade #17358

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Fixing pip installation after ubuntu upgrade #17358

merged 1 commit into from
Oct 16, 2024

Conversation

pranavbhole
Copy link
Contributor

@pranavbhole pranavbhole commented Oct 15, 2024 •
edited
Loading

Fixing pip installation after Ubuntu-latest tag update in GHA runners.

Creating python virtual env to install required custom packages.

actions/runner-images#10636
actions/runner-images#10783

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@pranavbhole pranavbhole marked this pull request as ready for review October 15, 2024 22:54
@github-actions github-actions bot added the GHA label Oct 15, 2024
imply-elliott
imply-elliott approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@imply-elliott imply-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚂

abhishekrb19
abhishekrb19 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@abhishekrb19 abhishekrb19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing our CI pipeline, @pranavbhole!

@abhishekrb19 abhishekrb19 merged commit f80e2c2 into apache:master Oct 16, 2024
90 checks passed
adithyachakilam pushed a commit to adithyachakilam/druid that referenced this pull request Oct 16, 2024
@pranavbhole @adithyachakilam
Fix pip installation after ubuntu upgrade (apache#17358)
9d86763
abhishekagarwal87 pushed a commit that referenced this pull request Oct 16, 2024
@pranavbhole @abhishekagarwal87
Fix pip installation after ubuntu upgrade (#17358)
9dac0f7
suneet-s pushed a commit that referenced this pull request Oct 17, 2024
@adithyachakilam @pranavbhole
supervisor/autoscaler: Fix clearing of collected lags on skipped scal…
e834e49 
…e actions (#17356)

* superviosr/autoscaler: Fix clearing of collected lags on skipped scale actions

* comments

* supervisor/autoscaler: Skip scaling when partitions are less than minTaskCount (#17335)

* Fix pip installation after ubuntu upgrade (#17358)

* fix tests

---------

Co-authored-by: Pranav <pranavbhole@gmail.com>
@adarshsanjeev adarshsanjeev added this to the 32.0.0 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imply-elliott imply-elliott imply-elliott approved these changes

@abhishekrb19 abhishekrb19 abhishekrb19 approved these changes

Assignees
No one assigned
Labels
Development Blocker GHA
Projects
None yet
Milestone
32.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pranavbhole @abhishekrb19 @imply-elliott @adarshsanjeev