Skip to content

Conversation

@pagrawal10
Copy link
Contributor

The current protobuf version has a CVE: https://avd.aquasec.com/nvd/2024/cve-2024-7254/
Updating to 4.28.2 fixes it.
I have verified from https://mvnrepository.com/artifact/com.google.protobuf/protobuf-java/4.28.2 that this does not have any compile dependencies.

Fixes #XXXX.

Description

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

Release note


Key changed/added classes in this PR
  • MyFoo
  • OurBar
  • TheirBaz

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

pom.xml Outdated
<netty4.version>4.1.108.Final</netty4.version>
<postgresql.version>42.7.2</postgresql.version>
<protobuf.version>3.24.0</protobuf.version>
<protobuf.version>4.28.2</protobuf.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the goal is to address the CVE, can we use 3.25.5 instead? 4.x is a big jump, which may require more validation.

@pagrawal10
Copy link
Contributor Author

Closing this PR as the version has been updated by #17249

@pagrawal10 pagrawal10 closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants