Upgrade commons-io to 2.17.0 #17227
Merged
Upgrade commons-io to 2.17.0 #17227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps commons-io:commons-io from 2.11.0 to 2.17.0. --- updated-dependencies: - dependency-name: commons-io:commons-io dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
kgyrtkirk
approved these changes
Oct 4, 2024
Comment on lines
-38
to
39
| <properties> | ||
| <commons-io.version>2.11.0</commons-io.version> | ||
| <commons-io.version>2.17.0</commons-io.version> | ||
| <okio.version>3.6.0</okio.version> |
Member
There was a problem hiding this comment.
note: setting the version in this submodule have not much meaning - as its configured with dependencyManagement at the top level pom; this and the version for the package can be removed..
this okio thing seems to be an interesting thing as well
it seems we have 3 versions of that lib loaded; so it might be
$ rebuild -Pdist -Pbundle-contrib-exts
$ tar tzf ./distribution/target/apache-druid-32.0.0-SNAPSHOT-bin.tar.gz |grep okio
apache-druid-32.0.0-SNAPSHOT/extensions/druid-iceberg-extensions/okio-2.8.0.jar
apache-druid-32.0.0-SNAPSHOT/extensions/druid-kubernetes-extensions/okio-jvm-3.6.0.jar
apache-druid-32.0.0-SNAPSHOT/extensions/druid-kubernetes-extensions/okio-3.6.0.jar
apache-druid-32.0.0-SNAPSHOT/extensions/druid-kubernetes-overlord-extensions/okio-1.15.0.jar
might worth a try to remove the version for that too and possibly declare its version via dependencyManagement in the root pom.xml in a separate pr
Contributor
Author
There was a problem hiding this comment.
you want me to remove commons io from submodule as part of this pr only or that too as another pr ?
Member
Contributor
Author
|
@kgyrtkirk Sure! Let me look at protobuf upgrade issue. |
airlock-confluentinc bot
pushed a commit
to confluentinc/druid
that referenced
this pull request
Oct 9, 2024
Co-authored-by: Shivam Garg <shigarg@visa.com>
cryptoe
pushed a commit
to cryptoe/druid
that referenced
this pull request
Oct 9, 2024
(cherry picked from commit 93b5a83)
abhishekagarwal87
pushed a commit
that referenced
this pull request
Oct 9, 2024
pagrawal10
added a commit
to confluentinc/druid
that referenced
this pull request
Oct 10, 2024
* Upgraded Protobuf to 3.25.5 (apache#17249) (#85) * Bump com.google.protobuf:protobuf-java from 3.24.0 to 3.25.5 Bumps [com.google.protobuf:protobuf-java](https://github.com/protocolbuffers/protobuf) from 3.24.0 to 3.25.5. - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl) - [Commits](protocolbuffers/protobuf@v3.24.0...v3.25.5) --- updated-dependencies: - dependency-name: com.google.protobuf:protobuf-java dependency-type: direct:production ... * Updated the license * Updated licenses.yaml --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Shivam Garg <shigarg@visa.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Upgrade commons-io to 2.17.0 (apache#17227) (#89) Co-authored-by: Shivam Garg <shigarg@visa.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Shivam Garg <shigarg@visa.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In latest version of commons-io IOException is replaced with UncheckedIOException
apache/commons-io@166dea3