Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: msq autocompaction #16681
docs: msq autocompaction #16681
Changes from 1 commit
7d5c8d3
63bc906
4c204e7
0f96df3
d118847
b698acf
0699168
c58b26b
5e08d07
802af43
30db2ba
56ede75
ea6c767
9defd6e
4fe38a7
790dcf0
ae5829b
ba1434a
1dfbb6b
52dfd51
a0e2b61
3e1bbf3
82baf46
632da59
390dd6a
1ea4fbd
9667d59
7fda723
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also add
engine
parameter hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that skipping it here and specifying it later in supervisor-based spec may be confusing. If we keep it here, just want to make sure that users realize that it's only supported with supervisors.
Also, we need to add this field to
Automatic compaction dynamic configuration
page. Maybe this info can reside there simiar to below:engine
| Engine for compaction. Can be eithernative
ormsq
. MSQ is only supported with compaction supervisors | no (default =native
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we also include the above on
Automatic compaction dynamic configuration
page?