Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curator 5.7.0 Upgrade #16617

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

razinbouzar
Copy link
Contributor

@razinbouzar razinbouzar commented Jun 17, 2024

Version bump of Curator from 5.3.0 to 5.7.0 due as as fix to CURATOR-696 being included in the new version.

Fixes #16411 in addition to reverting the change in #16425.

Description

This is a minor version bump of Curator.

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

Release note


Key changed/added classes in this PR
  • MyFoo
  • OurBar
  • TheirBaz

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Version bump of Curator
@razinbouzar
Copy link
Contributor Author

razinbouzar commented Jun 17, 2024

@kfaraz do you mind reviewing this version bump of Curator? @asdf2014 perhaps you can take a look as well since you submitted the original PR to revert.

@kfaraz kfaraz self-requested a review June 18, 2024 11:19
@kfaraz
Copy link
Contributor

kfaraz commented Jun 18, 2024

Thanks for keeping tabs on this, @razinbouzar !
I plan to take a look at this soon. Want to be sure if the other fix you did in #16528 would still be needed after this upgrade.

@gianm gianm added this to the 31.0.0 milestone Jul 2, 2024
@gianm
Copy link
Contributor

gianm commented Jul 2, 2024

Tagging with 31.0.0 to ensure we don't release 31.0.0 with the older Curator 5.3. We did 30.0.0 with Curator 5.5 (see #16445) and would want to release 31.0.0 with either Curator 5.5 or 5.7.

@kfaraz
Copy link
Contributor

kfaraz commented Sep 27, 2024

Removing this from Druid 31 milestone.

It had been originally included to ensure that Druid 31 was not released with Curator 5.3.
But since both master and 31.0.0 branch are already on Curator 5.5, this is not needed anymore.

As for upgrade to 5.7, it would require further testing.

@kfaraz kfaraz removed this from the 31.0.0 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 Coordinators Elected Leader
3 participants